2023-03-26 22:03:35

by Tom Rix

Subject: [PATCH] ALSA: remove unused loop_count variable

clang with W=1 reports
sound/pci/asihpi/hpi6000.c:1256:6: error: variable
'loop_count' set but not used [-Werror,-Wunused-but-set-variable]
u32 loop_count = 0;
^
This variable is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
sound/pci/asihpi/hpi6000.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/sound/pci/asihpi/hpi6000.c b/sound/pci/asihpi/hpi6000.c
index 88d902997b74..72aa135d69f8 100644
--- a/sound/pci/asihpi/hpi6000.c
+++ b/sound/pci/asihpi/hpi6000.c
@@ -1253,7 +1253,6 @@ static u16 hpi6000_dsp_block_read32(struct hpi_adapter_obj *pao,
int local_count = count;
int xfer_size;
u32 *pdata = dest;
- u32 loop_count = 0;

while (local_count) {
if (local_count > c6711_burst_size)
@@ -1273,7 +1272,6 @@ static u16 hpi6000_dsp_block_read32(struct hpi_adapter_obj *pao,
pdata += xfer_size;
local_hpi_address += sizeof(u32) * xfer_size;
local_count -= xfer_size;
- loop_count++;
}

if (time_out)
--
2.27.0

2023-03-29 12:47:16

by Takashi Iwai

Subject: Re: [PATCH] ALSA: remove unused loop_count variable

On Sun, 26 Mar 2023 22:57:12 +0200,
Tom Rix wrote:
>
> clang with W=1 reports
> sound/pci/asihpi/hpi6000.c:1256:6: error: variable
> 'loop_count' set but not used [-Werror,-Wunused-but-set-variable]
> u32 loop_count = 0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Applied, thanks.


Takashi