2023-04-06 01:44:46

by Li zeming

[permalink] [raw]
Subject: [PATCH v2] sched: rt: Simplify pick_next_rt_entity()

Remove useless intermediate variable "next" and its initialization.
Directly return the next RT scheduling entity obtained from
list_entry().

Signed-off-by: Li zeming <[email protected]>
Reviewed-by: Tim Chen <[email protected]>
---
v2: Simplify title and descriptive information.

kernel/sched/rt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 0a11f44adee5..e9b1c08c20a7 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1769,7 +1769,6 @@ static inline void set_next_task_rt(struct rq *rq, struct task_struct *p, bool f
static struct sched_rt_entity *pick_next_rt_entity(struct rt_rq *rt_rq)
{
struct rt_prio_array *array = &rt_rq->active;
- struct sched_rt_entity *next = NULL;
struct list_head *queue;
int idx;

@@ -1779,9 +1778,8 @@ static struct sched_rt_entity *pick_next_rt_entity(struct rt_rq *rt_rq)
queue = array->queue + idx;
if (SCHED_WARN_ON(list_empty(queue)))
return NULL;
- next = list_entry(queue->next, struct sched_rt_entity, run_list);

- return next;
+ return list_entry(queue->next, struct sched_rt_entity, run_list);
}

static struct task_struct *_pick_next_task_rt(struct rq *rq)
--
2.18.2