2023-04-26 07:43:40

by Zong Li

[permalink] [raw]
Subject: [PATCH] dmaengine: xilinx: enable on RISC-V platform

Enable the xilinx dmaengine driver on RISC-V platform. We have verified
the CDMA on RISC-V platform, enable this configuration to allow build on
RISC-V.

Signed-off-by: Zong Li <[email protected]>
---
drivers/dma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index fb7073fc034f..816f619804b9 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -695,7 +695,7 @@ config XGENE_DMA

config XILINX_DMA
tristate "Xilinx AXI DMAS Engine"
- depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
+ depends on (ARCH_ZYNQ || MICROBLAZE || ARM64 || RISCV)
select DMA_ENGINE
help
Enable support for Xilinx AXI VDMA Soft IP.
--
2.17.1


2023-04-26 14:50:36

by Palmer Dabbelt

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: xilinx: enable on RISC-V platform

On Wed, 26 Apr 2023 00:42:48 PDT (-0700), [email protected] wrote:
> Enable the xilinx dmaengine driver on RISC-V platform. We have verified
> the CDMA on RISC-V platform, enable this configuration to allow build on
> RISC-V.
>
> Signed-off-by: Zong Li <[email protected]>
> ---
> drivers/dma/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index fb7073fc034f..816f619804b9 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -695,7 +695,7 @@ config XGENE_DMA
>
> config XILINX_DMA
> tristate "Xilinx AXI DMAS Engine"
> - depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> + depends on (ARCH_ZYNQ || MICROBLAZE || ARM64 || RISCV)
> select DMA_ENGINE
> help
> Enable support for Xilinx AXI VDMA Soft IP.

Acked-by: Palmer Dabbelt <[email protected]>

2023-05-04 09:16:16

by Zong Li

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: xilinx: enable on RISC-V platform

On Wed, Apr 26, 2023 at 10:28 PM Palmer Dabbelt <[email protected]> wrote:
>
> On Wed, 26 Apr 2023 00:42:48 PDT (-0700), [email protected] wrote:
> > Enable the xilinx dmaengine driver on RISC-V platform. We have verified
> > the CDMA on RISC-V platform, enable this configuration to allow build on
> > RISC-V.
> >
> > Signed-off-by: Zong Li <[email protected]>
> > ---
> > drivers/dma/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > index fb7073fc034f..816f619804b9 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -695,7 +695,7 @@ config XGENE_DMA
> >
> > config XILINX_DMA
> > tristate "Xilinx AXI DMAS Engine"
> > - depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> > + depends on (ARCH_ZYNQ || MICROBLAZE || ARM64 || RISCV)
> > select DMA_ENGINE
> > help
> > Enable support for Xilinx AXI VDMA Soft IP.
>
> Acked-by: Palmer Dabbelt <[email protected]>

Hi Palmer,
Thanks for your review.

Hi Vinod,
Could I know if this patch also meets your expectations? If it does,
would you please consider accepting it?
Thanks.

2023-05-04 14:28:26

by Pandey, Radhey Shyam

[permalink] [raw]
Subject: RE: [PATCH] dmaengine: xilinx: enable on RISC-V platform

> -----Original Message-----
> From: linux-riscv <[email protected]> On Behalf Of
> Zong Li
> Sent: Wednesday, April 26, 2023 1:13 PM
> To: [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Cc: Zong Li <[email protected]>
> Subject: [PATCH] dmaengine: xilinx: enable on RISC-V platform
>
> Enable the xilinx dmaengine driver on RISC-V platform. We have verified the
> CDMA on RISC-V platform, enable this configuration to allow build on RISC-V.
>
> Signed-off-by: Zong Li <[email protected]>
> ---
> drivers/dma/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index
> fb7073fc034f..816f619804b9 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -695,7 +695,7 @@ config XGENE_DMA
>
> config XILINX_DMA
> tristate "Xilinx AXI DMAS Engine"
> - depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> + depends on (ARCH_ZYNQ || MICROBLAZE || ARM64 || RISCV)

Instead of adding one more dependency I think we can cleanup this
dependency list. Similar changes done in ethernet subsystem. Please
have a look at below commits:

e8b6c54f6d57 net: xilinx: temac: Relax Kconfig dependencies
d7eaf962a90b net: axienet: In kconfig remove arch dependency for axi_emac

> select DMA_ENGINE
> help
> Enable support for Xilinx AXI VDMA Soft IP.
> --
> 2.17.1
>
>
> _______________________________________________
> linux-riscv mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-riscv

2023-05-05 00:53:55

by Zong Li

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: xilinx: enable on RISC-V platform

On Thu, May 4, 2023 at 10:17 PM Pandey, Radhey Shyam
<[email protected]> wrote:
>
> > -----Original Message-----
> > From: linux-riscv <[email protected]> On Behalf Of
> > Zong Li
> > Sent: Wednesday, April 26, 2023 1:13 PM
> > To: [email protected]; [email protected]; linux-
> > [email protected]; [email protected]
> > Cc: Zong Li <[email protected]>
> > Subject: [PATCH] dmaengine: xilinx: enable on RISC-V platform
> >
> > Enable the xilinx dmaengine driver on RISC-V platform. We have verified the
> > CDMA on RISC-V platform, enable this configuration to allow build on RISC-V.
> >
> > Signed-off-by: Zong Li <[email protected]>
> > ---
> > drivers/dma/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index
> > fb7073fc034f..816f619804b9 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -695,7 +695,7 @@ config XGENE_DMA
> >
> > config XILINX_DMA
> > tristate "Xilinx AXI DMAS Engine"
> > - depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> > + depends on (ARCH_ZYNQ || MICROBLAZE || ARM64 || RISCV)
>
> Instead of adding one more dependency I think we can cleanup this
> dependency list. Similar changes done in ethernet subsystem. Please
> have a look at below commits:
>

Hi Pandey,
Thanks for your tips, let me take a look at it, and give the next version.

> e8b6c54f6d57 net: xilinx: temac: Relax Kconfig dependencies
> d7eaf962a90b net: axienet: In kconfig remove arch dependency for axi_emac
>
> > select DMA_ENGINE
> > help
> > Enable support for Xilinx AXI VDMA Soft IP.
> > --
> > 2.17.1
> >
> >
> > _______________________________________________
> > linux-riscv mailing list
> > [email protected]
> > http://lists.infradead.org/mailman/listinfo/linux-riscv