2023-05-16 22:57:01

by Sidhartha Kumar

Subject: [PATCH] mm/hugetlb: remove hugetlb_page_subpool()

All users of hugetlb_page_subpool() have been converted to use the folio
equivalent. This function can be safely removed.

Signed-off-by: Sidhartha Kumar <[email protected]>
---
include/linux/hugetlb.h | 13 -------------
1 file changed, 13 deletions(-)

diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index b2b698f9a2ecb..21f942025fecd 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
return folio->_hugetlb_subpool;
}

-/*
- * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool
- */
-static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
-{
- return hugetlb_folio_subpool(page_folio(hpage));
-}
-
static inline void hugetlb_set_folio_subpool(struct folio *folio,
struct hugepage_subpool *subpool)
{
@@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
return NULL;
}

-static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
-{
- return NULL;
-}
-
static inline int isolate_or_dissolve_huge_page(struct page *page,
struct list_head *list)
{
--
2.40.1

2023-05-16 23:15:02

by Mike Kravetz

Subject: Re: [PATCH] mm/hugetlb: remove hugetlb_page_subpool()

On 05/16/23 15:52, Sidhartha Kumar wrote:
> All users of hugetlb_page_subpool() have been converted to use the folio
> equivalent. This function can be safely removed.
>
> Signed-off-by: Sidhartha Kumar <[email protected]>
> ---
> include/linux/hugetlb.h | 13 -------------
> 1 file changed, 13 deletions(-)

Thanks!

Reviewed-by: Mike Kravetz <[email protected]>
--
Mike Kravetz

>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index b2b698f9a2ecb..21f942025fecd 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
> return folio->_hugetlb_subpool;
> }
>
> -/*
> - * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool
> - */
> -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> -{
> - return hugetlb_folio_subpool(page_folio(hpage));
> -}
> -
> static inline void hugetlb_set_folio_subpool(struct folio *folio,
> struct hugepage_subpool *subpool)
> {
> @@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
> return NULL;
> }
>
> -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> -{
> - return NULL;
> -}
> -
> static inline int isolate_or_dissolve_huge_page(struct page *page,
> struct list_head *list)
> {
> --
> 2.40.1
>

2023-05-17 07:30:01

by David Hildenbrand

Subject: Re: [PATCH] mm/hugetlb: remove hugetlb_page_subpool()

On 17.05.23 00:52, Sidhartha Kumar wrote:
> All users of hugetlb_page_subpool() have been converted to use the folio
> equivalent. This function can be safely removed.
>
> Signed-off-by: Sidhartha Kumar <[email protected]>
> ---
> include/linux/hugetlb.h | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index b2b698f9a2ecb..21f942025fecd 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
> return folio->_hugetlb_subpool;
> }
>
> -/*
> - * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool
> - */
> -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> -{
> - return hugetlb_folio_subpool(page_folio(hpage));
> -}
> -
> static inline void hugetlb_set_folio_subpool(struct folio *folio,
> struct hugepage_subpool *subpool)
> {
> @@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
> return NULL;
> }
>
> -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> -{
> - return NULL;
> -}
> -
> static inline int isolate_or_dissolve_huge_page(struct page *page,
> struct list_head *list)
> {


Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb