2023-05-23 21:07:32

by Kalesh Singh

Subject: [PATCH] mm-unstable: Multi-gen LRU: Fix workingset accounting

On Android app cycle workloads, MGLRU showed a significant reduction
in workingset refaults although pgpgin/pswpin remained relatively
unchanged. This indicated MGLRU may be undercounting workingset
refaults.

This has impact on userspace programs, like Android's LMKD, that
monitor workingset refault statistics to detect thrashing.

It was found that refaults were only accounted if the MGLRU shadow
entry was for a recently evicted folio. However, recently evicted
folios should be accounted as workingset activation, and refaults
should be accounted regardless of recency.

Fix MGLRU's workingset refault and activation accounting to more
closely match that of the conventional active/inactive LRU.

Fixes: ac35a4902374 ("mm: multi-gen LRU: minimal implementation")
Cc: Yu Zhao <[email protected]>
Cc: Andrew Morton <[email protected]>
Reported-by: Charan Teja Kalla <[email protected]>
Signed-off-by: Kalesh Singh <[email protected]>
---
mm/vmscan.c | 1 -
mm/workingset.c | 10 +++++++---
2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index eeca83e28c9b..ef687f9be13c 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -4925,7 +4925,6 @@ static bool sort_folio(struct lruvec *lruvec, struct folio *folio, int tier_idx)

WRITE_ONCE(lrugen->protected[hist][type][tier - 1],
lrugen->protected[hist][type][tier - 1] + delta);
- __mod_lruvec_state(lruvec, WORKINGSET_ACTIVATE_BASE + type, delta);
return true;
}

diff --git a/mm/workingset.c b/mm/workingset.c
index 5796e927e6d7..4686ae363000 100644
--- a/mm/workingset.c
+++ b/mm/workingset.c
@@ -278,6 +278,7 @@ static bool lru_gen_test_recent(void *shadow, bool file, struct lruvec **lruvec,

static void lru_gen_refault(struct folio *folio, void *shadow)
{
+ bool recent;
int hist, tier, refs;
bool workingset;
unsigned long token;
@@ -288,10 +289,13 @@ static void lru_gen_refault(struct folio *folio, void *shadow)

rcu_read_lock();

- if (!lru_gen_test_recent(shadow, type, &lruvec, &token, &workingset))
+ recent = lru_gen_test_recent(shadow, type, &lruvec, &token, &workingset);
+ if (lruvec != folio_lruvec(folio))
goto unlock;

- if (lruvec != folio_lruvec(folio))
+ mod_lruvec_state(lruvec, WORKINGSET_REFAULT_BASE + type, delta);
+
+ if (!recent)
goto unlock;

lrugen = &lruvec->lrugen;
@@ -302,7 +306,7 @@ static void lru_gen_refault(struct folio *folio, void *shadow)
tier = lru_tier_from_refs(refs);

atomic_long_add(delta, &lrugen->refaulted[hist][type][tier]);
- mod_lruvec_state(lruvec, WORKINGSET_REFAULT_BASE + type, delta);
+ mod_lruvec_state(lruvec, WORKINGSET_ACTIVATE_BASE + type, delta);

/*
* Count the following two cases as stalls:

base-commit: cd255dae35f51ea33cb85d29720d6b4e5fa16365
--
2.40.1.698.g37aff9b760-goog

2023-05-23 22:43:38

by Yu Zhao

Subject: Re: [PATCH] mm-unstable: Multi-gen LRU: Fix workingset accounting

On Tue, May 23, 2023 at 2:59 PM Kalesh Singh <[email protected]> wrote:
>
> On Android app cycle workloads, MGLRU showed a significant reduction
> in workingset refaults although pgpgin/pswpin remained relatively
> unchanged. This indicated MGLRU may be undercounting workingset
> refaults.
>
> This has impact on userspace programs, like Android's LMKD, that
> monitor workingset refault statistics to detect thrashing.
>
> It was found that refaults were only accounted if the MGLRU shadow
> entry was for a recently evicted folio. However, recently evicted
> folios should be accounted as workingset activation, and refaults
> should be accounted regardless of recency.
>
> Fix MGLRU's workingset refault and activation accounting to more
> closely match that of the conventional active/inactive LRU.
>
> Fixes: ac35a4902374 ("mm: multi-gen LRU: minimal implementation")
> Cc: Yu Zhao <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Reported-by: Charan Teja Kalla <[email protected]>
> Signed-off-by: Kalesh Singh <[email protected]>

Acked-by: Yu Zhao <[email protected]>