2023-06-02 13:22:54

by Jorge Lopez

[permalink] [raw]
Subject: [PATCH v16 01/13] hp-bioscfg: Documentation

HP BIOS Configuration driver purpose is to provide a driver supporting
the latest sysfs class firmware attributes framework allowing the user
to change BIOS settings and security solutions on HP Inc.’s commercial
notebooks.

Many features of HP Commercial notebooks can be managed using Windows
Management Instrumentation (WMI). WMI is an implementation of Web-Based
Enterprise Management (WBEM) that provides a standards-based interface
for changing and monitoring system settings. HP BIOSCFG driver provides
a native Linux solution and the exposed features facilitates the
migration to Linux environments.

The Linux security features to be provided in hp-bioscfg driver enables
managing the BIOS settings and security solutions via sysfs, a virtual
filesystem that can be used by user-mode applications. The new
documentation cover HP-specific firmware sysfs attributes such Secure
Platform Management and Sure Start. Each section provides security
feature description and identifies sysfs directories and files exposed
by the driver.

Many HP Commercial notebooks include a feature called Secure Platform
Management (SPM), which replaces older password-based BIOS settings
management with public key cryptography. PC secure product management
begins when a target system is provisioned with cryptographic keys
that are used to ensure the integrity of communications between system
management utilities and the BIOS.

HP Commercial notebooks have several BIOS settings that control its
behaviour and capabilities, many of which are related to security.
To prevent unauthorized changes to these settings, the system can
be configured to use a cryptographic signature-based authorization
string that the BIOS will use to verify authorization to modify the
setting.

Linux Security components are under development and not published yet.
The only linux component is the driver (hp bioscfg) at this time.
Other published security components are under Windows.

Signed-off-by: Jorge Lopez <[email protected]>

---
Based on the latest platform-drivers-x86.git/for-next
---
.../testing/sysfs-class-firmware-attributes | 101 +++++++++++++++++-
1 file changed, 99 insertions(+), 2 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-class-firmware-attributes b/Documentation/ABI/testing/sysfs-class-firmware-attributes
index 4cdba3477176..df9904b9f39c 100644
--- a/Documentation/ABI/testing/sysfs-class-firmware-attributes
+++ b/Documentation/ABI/testing/sysfs-class-firmware-attributes
@@ -22,6 +22,11 @@ Description:
- integer: a range of numerical values
- string

+ HP specific types
+ -----------------
+ - ordered-list - a set of ordered list valid values
+
+
All attribute types support the following values:

current_value:
@@ -126,6 +131,21 @@ Description:
value will not be effective through sysfs until this rule is
met.

+ HP specific class extensions
+ ------------------------------
+
+ On HP systems the following additional attributes are available:
+
+ "ordered-list"-type specific properties:
+
+ elements:
+ A file that can be read to obtain the possible
+ list of values of the <attr>. Values are separated using
+ semi-colon (``;``) and listed according to their priority.
+ An element listed first has the highest priority. Writing
+ the list in a different order to current_value alters
+ the priority order for the particular attribute.
+
What: /sys/class/firmware-attributes/*/authentication/
Date: February 2021
KernelVersion: 5.11
@@ -206,7 +226,7 @@ Description:
Drivers may emit a CHANGE uevent when a password is set or unset
userspace may check it again.

- On Dell and Lenovo systems, if Admin password is set, then all BIOS attributes
+ On Dell, Lenovo and HP systems, if Admin password is set, then all BIOS attributes
require password validation.
On Lenovo systems if you change the Admin password the new password is not active until
the next boot.
@@ -296,6 +316,15 @@ Description:
echo "signature" > authentication/Admin/signature
echo "password" > authentication/Admin/certificate_to_password

+ HP specific class extensions
+ --------------------------------
+
+ On HP systems the following additional settings are available:
+
+ role: enhanced-bios-auth:
+ This role is specific to Secure Platform Management (SPM) attribute.
+ It requires configuring an endorsement (kek) and signing certificate (sk).
+

What: /sys/class/firmware-attributes/*/attributes/pending_reboot
Date: February 2021
@@ -311,7 +340,7 @@ Description:
== =========================================
0 All BIOS attributes setting are current
1 A reboot is necessary to get pending BIOS
- attribute changes applied
+ attribute changes applied
== =========================================

Note, userspace applications need to follow below steps for efficient
@@ -364,3 +393,71 @@ Description:
use it to enable extra debug attributes or BIOS features for testing purposes.

Note that any changes to this attribute requires a reboot for changes to take effect.
+
+
+ HP specific class extensions - Secure Platform Manager (SPM)
+ --------------------------------
+
+What: /sys/class/firmware-attributes/*/authentication/SPM/kek
+Date: March 2023
+KernelVersion: 5.18
+Contact: "Jorge Lopez" <[email protected]>
+Description:
+ 'kek' Key-Encryption-Key is a write-only file that can be used to configure the
+ RSA public key that will be used by the BIOS to verify
+ signatures when setting the signing key. When written,
+ the bytes should correspond to the KEK certificate
+ (x509 .DER format containing an OU). The size of the
+ certificate must be less than or equal to 4095 bytes.
+
+What: /sys/class/firmware-attributes/*/authentication/SPM/sk
+Date: March 2023
+KernelVersion: 5.18
+Contact: "Jorge Lopez" <[email protected]>
+Description:
+ 'sk' Signature Key is a write-only file that can be used to configure the RSA
+ public key that will be used by the BIOS to verify signatures
+ when configuring BIOS settings and security features. When
+ written, the bytes should correspond to the modulus of the
+ public key. The exponent is assumed to be 0x10001.
+
+What: /sys/class/firmware-attributes/*/authentication/SPM/status
+Date: March 2023
+KernelVersion: 5.18
+Contact: "Jorge Lopez" <[email protected]>
+Description:
+ 'status' is a read-only file that returns ASCII text in JSON format reporting
+ the status information.
+
+ "State": "not provisioned | provisioned | provisioning in progress ",
+ "Version": " Major. Minor ",
+ "Nonce": <16-bit unsigned number display in base 10>,
+ "FeaturesInUse": <16-bit unsigned number display in base 10>,
+ "EndorsementKeyMod": "<256 bytes in base64>",
+ "SigningKeyMod": "<256 bytes in base64>"
+
+What: /sys/class/firmware-attributes/*/attributes/Sure_Start/audit_log_entries
+Date: March 2023
+KernelVersion: 5.18
+Contact: "Jorge Lopez" <[email protected]>
+Description:
+ 'audit_log_entries' is a read-only file that returns the events in the log.
+
+ Audit log entry format
+
+ Byte 0-15: Requested Audit Log entry (Each Audit log is 16 bytes)
+ Byte 16-127: Unused
+
+What: /sys/class/firmware-attributes/*/attributes/Sure_Start/audit_log_entry_count
+Date: March 2023
+KernelVersion: 5.18
+Contact: "Jorge Lopez" <[email protected]>
+Description:
+ 'audit_log_entry_count' is a read-only file that returns the number of existing
+ audit log events available to be read. Values are separated using comma (``,``)
+
+ [No of entries],[log entry size],[Max number of entries supported]
+
+ log entry size identifies audit log size for the current BIOS version.
+ The current size is 16 bytes but it can be up to 128 bytes long in future BIOS
+ versions.
--
2.34.1



2023-06-02 23:07:22

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH v16 01/13] hp-bioscfg: Documentation



On 6/2/23 06:10, Jorge Lopez wrote:

>
> Signed-off-by: Jorge Lopez <[email protected]>
>
> ---
> Based on the latest platform-drivers-x86.git/for-next
> ---
> .../testing/sysfs-class-firmware-attributes | 101 +++++++++++++++++-
> 1 file changed, 99 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-firmware-attributes b/Documentation/ABI/testing/sysfs-class-firmware-attributes
> index 4cdba3477176..df9904b9f39c 100644
> --- a/Documentation/ABI/testing/sysfs-class-firmware-attributes
> +++ b/Documentation/ABI/testing/sysfs-class-firmware-attributes
> @@ -126,6 +131,21 @@ Description:
> value will not be effective through sysfs until this rule is
> met.
>
> + HP specific class extensions
> + ------------------------------
> +
> + On HP systems the following additional attributes are available:
> +
> + "ordered-list"-type specific properties:
> +
> + elements:
> + A file that can be read to obtain the possible
> + list of values of the <attr>. Values are separated using
> + semi-colon (``;``) and listed according to their priority.
> + An element listed first has the highest priority. Writing
> + the list in a different order to current_value alters
> + the priority order for the particular attribute.
> +
> What: /sys/class/firmware-attributes/*/authentication/
> Date: February 2021
> KernelVersion: 5.11

Why 5.11 and that date?

> @@ -364,3 +393,71 @@ Description:
> use it to enable extra debug attributes or BIOS features for testing purposes.
>
> Note that any changes to this attribute requires a reboot for changes to take effect.
> +
> +
> + HP specific class extensions - Secure Platform Manager (SPM)
> + --------------------------------
> +
> +What: /sys/class/firmware-attributes/*/authentication/SPM/kek
> +Date: March 2023
> +KernelVersion: 5.18

Why 5.18 and that date?

> +Contact: "Jorge Lopez" <[email protected]>
> +Description:
> + 'kek' Key-Encryption-Key is a write-only file that can be used to configure the
> + RSA public key that will be used by the BIOS to verify
> + signatures when setting the signing key. When written,
> + the bytes should correspond to the KEK certificate
> + (x509 .DER format containing an OU). The size of the
> + certificate must be less than or equal to 4095 bytes.
> +
> +What: /sys/class/firmware-attributes/*/authentication/SPM/sk
> +Date: March 2023
> +KernelVersion: 5.18

Why 5.18 and that date?

> +Contact: "Jorge Lopez" <[email protected]>
> +Description:
> + 'sk' Signature Key is a write-only file that can be used to configure the RSA
> + public key that will be used by the BIOS to verify signatures
> + when configuring BIOS settings and security features. When
> + written, the bytes should correspond to the modulus of the
> + public key. The exponent is assumed to be 0x10001.
> +
> +What: /sys/class/firmware-attributes/*/authentication/SPM/status
> +Date: March 2023
> +KernelVersion: 5.18

Why 5.18 and that date?

> +Contact: "Jorge Lopez" <[email protected]>
> +Description:
> + 'status' is a read-only file that returns ASCII text in JSON format reporting
> + the status information.
> +
> + "State": "not provisioned | provisioned | provisioning in progress ",

Drop the space after "in progress" ?

> + "Version": " Major. Minor ",

So Major. should have a space before and after it? and Minor should have a space after it?

> + "Nonce": <16-bit unsigned number display in base 10>,
> + "FeaturesInUse": <16-bit unsigned number display in base 10>,
> + "EndorsementKeyMod": "<256 bytes in base64>",
> + "SigningKeyMod": "<256 bytes in base64>"
> +
> +What: /sys/class/firmware-attributes/*/attributes/Sure_Start/audit_log_entries
> +Date: March 2023
> +KernelVersion: 5.18

Why 5.18 and that date?

> +Contact: "Jorge Lopez" <[email protected]>
> +Description:
> + 'audit_log_entries' is a read-only file that returns the events in the log.
> +
> + Audit log entry format
> +
> + Byte 0-15: Requested Audit Log entry (Each Audit log is 16 bytes)
> + Byte 16-127: Unused
> +
> +What: /sys/class/firmware-attributes/*/attributes/Sure_Start/audit_log_entry_count
> +Date: March 2023
> +KernelVersion: 5.18

Why 5.18 and that date?

> +Contact: "Jorge Lopez" <[email protected]>
> +Description:
> + 'audit_log_entry_count' is a read-only file that returns the number of existing
> + audit log events available to be read. Values are separated using comma (``,``)

End the sentence above with a '.' please.

> +
> + [No of entries],[log entry size],[Max number of entries supported]
> +
> + log entry size identifies audit log size for the current BIOS version.
> + The current size is 16 bytes but it can be up to 128 bytes long in future BIOS
> + versions.

Thanks.
--
~Randy

2023-06-05 14:02:41

by Jorge Lopez

[permalink] [raw]
Subject: Re: [PATCH v16 01/13] hp-bioscfg: Documentation

On Fri, Jun 2, 2023 at 5:55 PM Randy Dunlap <[email protected]> wrote:
>
>
>
> On 6/2/23 06:10, Jorge Lopez wrote:
>
> >
> > Signed-off-by: Jorge Lopez <[email protected]>
> >
> > ---
> > Based on the latest platform-drivers-x86.git/for-next
> > ---
> > .../testing/sysfs-class-firmware-attributes | 101 +++++++++++++++++-
> > 1 file changed, 99 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-class-firmware-attributes b/Documentation/ABI/testing/sysfs-class-firmware-attributes
> > index 4cdba3477176..df9904b9f39c 100644
> > --- a/Documentation/ABI/testing/sysfs-class-firmware-attributes
> > +++ b/Documentation/ABI/testing/sysfs-class-firmware-attributes
> > @@ -126,6 +131,21 @@ Description:
> > value will not be effective through sysfs until this rule is
> > met.
> >
> > + HP specific class extensions
> > + ------------------------------
> > +
> > + On HP systems the following additional attributes are available:
> > +
> > + "ordered-list"-type specific properties:
> > +
> > + elements:
> > + A file that can be read to obtain the possible
> > + list of values of the <attr>. Values are separated using
> > + semi-colon (``;``) and listed according to their priority.
> > + An element listed first has the highest priority. Writing
> > + the list in a different order to current_value alters
> > + the priority order for the particular attribute.
> > +
> > What: /sys/class/firmware-attributes/*/authentication/
> > Date: February 2021
> > KernelVersion: 5.11
>
> Why 5.11 and that date?

Date and Kernel values were provided by an earlier submitter.

>
> > @@ -364,3 +393,71 @@ Description:
> > use it to enable extra debug attributes or BIOS features for testing purposes.
> >
> > Note that any changes to this attribute requires a reboot for changes to take effect.
> > +
> > +
> > + HP specific class extensions - Secure Platform Manager (SPM)
> > + --------------------------------
> > +
> > +What: /sys/class/firmware-attributes/*/authentication/SPM/kek
> > +Date: March 2023
> > +KernelVersion: 5.18
>
> Why 5.18 and that date?

It is the minimum kernel version where firmware-attributes are
supported and date when we expected hp-bioscfg driver support to be
available.
The driver, kernel versions and date changes weekly so we were placing
those dates and versions as tentative.
Any suggestions for Date and KernelVersion fields?

>
> > +Contact: "Jorge Lopez" <[email protected]>
> > +Description:
> > + 'kek' Key-Encryption-Key is a write-only file that can be used to configure the
> > + RSA public key that will be used by the BIOS to verify
> > + signatures when setting the signing key. When written,
> > + the bytes should correspond to the KEK certificate
> > + (x509 .DER format containing an OU). The size of the
> > + certificate must be less than or equal to 4095 bytes.
> > +
> > +What: /sys/class/firmware-attributes/*/authentication/SPM/sk
> > +Date: March 2023
> > +KernelVersion: 5.18
>
> Why 5.18 and that date?

See previous explanation.

>
> > +Contact: "Jorge Lopez" <[email protected]>
> > +Description:
> > + 'sk' Signature Key is a write-only file that can be used to configure the RSA
> > + public key that will be used by the BIOS to verify signatures
> > + when configuring BIOS settings and security features. When
> > + written, the bytes should correspond to the modulus of the
> > + public key. The exponent is assumed to be 0x10001.
> > +
> > +What: /sys/class/firmware-attributes/*/authentication/SPM/status
> > +Date: March 2023
> > +KernelVersion: 5.18
>
> Why 5.18 and that date?

See previous explanation.

>
> > +Contact: "Jorge Lopez" <[email protected]>
> > +Description:
> > + 'status' is a read-only file that returns ASCII text in JSON format reporting
> > + the status information.
> > +
> > + "State": "not provisioned | provisioned | provisioning in progress ",
>
> Drop the space after "in progress" ?

Done!

>
> > + "Version": " Major. Minor ",
>
> So Major. should have a space before and after it? and Minor should have a space after it?

Neither. I will remove the space before and after for both Major and
Minor. "Major.Minor"

>
> > + "Nonce": <16-bit unsigned number display in base 10>,
> > + "FeaturesInUse": <16-bit unsigned number display in base 10>,
> > + "EndorsementKeyMod": "<256 bytes in base64>",
> > + "SigningKeyMod": "<256 bytes in base64>"
> > +
> > +What: /sys/class/firmware-attributes/*/attributes/Sure_Start/audit_log_entries
> > +Date: March 2023
> > +KernelVersion: 5.18
>
> Why 5.18 and that date?

It is the minimum kernel version where firmware-attributes are
supported and date when we expected hp-bioscfg driver support to be
available.
The driver, kernel versions and date changes weekly so we were placing
those dates and versions as tentative.
Any suggestions for Date and KernelVersion fields?

>
> > +Contact: "Jorge Lopez" <[email protected]>
> > +Description:
> > + 'audit_log_entries' is a read-only file that returns the events in the log.
> > +
> > + Audit log entry format
> > +
> > + Byte 0-15: Requested Audit Log entry (Each Audit log is 16 bytes)
> > + Byte 16-127: Unused
> > +
> > +What: /sys/class/firmware-attributes/*/attributes/Sure_Start/audit_log_entry_count
> > +Date: March 2023
> > +KernelVersion: 5.18
>
> Why 5.18 and that date?

See earlier explanation

>
> > +Contact: "Jorge Lopez" <[email protected]>
> > +Description:
> > + 'audit_log_entry_count' is a read-only file that returns the number of existing
> > + audit log events available to be read. Values are separated using comma (``,``)
>
> End the sentence above with a '.' please.

Done!

>
> > +
> > + [No of entries],[log entry size],[Max number of entries supported]
> > +
> > + log entry size identifies audit log size for the current BIOS version.
> > + The current size is 16 bytes but it can be up to 128 bytes long in future BIOS
> > + versions.
>
> Thanks.
> --
> ~Randy

2023-06-05 15:33:57

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH v16 01/13] hp-bioscfg: Documentation

Hi,

On 6/5/23 06:32, Jorge Lopez wrote:
> On Fri, Jun 2, 2023 at 5:55 PM Randy Dunlap <[email protected]> wrote:
>>
>>
>>
>> On 6/2/23 06:10, Jorge Lopez wrote:
>>
>>>
>>> Signed-off-by: Jorge Lopez <[email protected]>
>>>
>>> ---
>>> Based on the latest platform-drivers-x86.git/for-next
>>> ---
>>> .../testing/sysfs-class-firmware-attributes | 101 +++++++++++++++++-
>>> 1 file changed, 99 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/ABI/testing/sysfs-class-firmware-attributes b/Documentation/ABI/testing/sysfs-class-firmware-attributes
>>> index 4cdba3477176..df9904b9f39c 100644
>>> --- a/Documentation/ABI/testing/sysfs-class-firmware-attributes
>>> +++ b/Documentation/ABI/testing/sysfs-class-firmware-attributes

>>> @@ -364,3 +393,71 @@ Description:
>>> use it to enable extra debug attributes or BIOS features for testing purposes.
>>>
>>> Note that any changes to this attribute requires a reboot for changes to take effect.
>>> +
>>> +
>>> + HP specific class extensions - Secure Platform Manager (SPM)
>>> + --------------------------------
>>> +
>>> +What: /sys/class/firmware-attributes/*/authentication/SPM/kek
>>> +Date: March 2023
>>> +KernelVersion: 5.18
>>
>> Why 5.18 and that date?
>
> It is the minimum kernel version where firmware-attributes are
> supported and date when we expected hp-bioscfg driver support to be
> available.
> The driver, kernel versions and date changes weekly so we were placing
> those dates and versions as tentative.
> Any suggestions for Date and KernelVersion fields?
>

No, sorry. But the different dates and versions are confusing.


Thanks for the answers.

--
~Randy