2023-06-07 09:04:14

by Varadarajan Narayanan

[permalink] [raw]
Subject: [PATCH v6 0/3] Enable IPQ9574 TSENS support

This patch set enables tsens in IPQ9574

Depends on
https://lore.kernel.org/linux-arm-msm/[email protected]/
[v6]:
Remove comments from tsens node in dtsi
[v5]:
Fix make DT_CHECKER_FLAGS=-m dt_binding_check and make dtbs_check errors without removing existing entries

[v4]:
Drop the sm6375-tsens and qcm2290-tsens related bindings
fix as it is already posted

Remove unnecessary changes from previous version

[v3]:
Fix make DT_CHECKER_FLAGS=-m dt_binding_check and make dtbs_check errors

[v2]:
Drop the driver change (https://lore.kernel.org/lkml/b45d33d38a334aabbd52c83b0d6028af1f4c74c8.1682682753.git.quic_varada@quicinc.com/)
since the tsens device is compatible with 8074's tsens
and use 8074's compatible itself

Rename clusterX nodes as cpussX

[v1]:
Fix DT node names

[v0]:
Initial patch introducing TSENS support

Praveenkumar I (1):
dt-bindings: thermal: tsens: Add ipq9574 compatible

Varadarajan Narayanan (2):
arm64: dts: qcom: ipq9574: add tsens node
arm64: dts: qcom: ipq9574: add thermal zone nodes

.../devicetree/bindings/thermal/qcom-tsens.yaml | 6 +
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 218 +++++++++++++++++++++
2 files changed, 224 insertions(+)

--
2.7.4



2023-06-07 09:05:29

by Varadarajan Narayanan

[permalink] [raw]
Subject: [PATCH v6 2/3] arm64: dts: qcom: ipq9574: add tsens node

IPQ9574 has a tsens v2.3.1 peripheral which monitors temperatures
around the various subsystems on the die.

Reviewed-by: Konrad Dybcio <[email protected]>
Co-developed-by: Praveenkumar I <[email protected]>
Signed-off-by: Praveenkumar I <[email protected]>
Signed-off-by: Varadarajan Narayanan <[email protected]>
---
[v6]:
Remove comments from tsens node
[v5]:
Pad "reg" address value to 8 digits

[v2]:
Add "qcom,ipq8074-tsens" as fallback compatible
---
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 0baeb10..a436bf2 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -206,6 +206,16 @@
#size-cells = <1>;
};

+ tsens: thermal-sensor@4a9000 {
+ compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens";
+ reg = <0x004a9000 0x1000>,
+ <0x004a8000 0x1000>;
+ interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "combined";
+ #qcom,sensors = <16>;
+ #thermal-sensor-cells = <1>;
+ };
+
tlmm: pinctrl@1000000 {
compatible = "qcom,ipq9574-tlmm";
reg = <0x01000000 0x300000>;
--
2.7.4


2023-06-07 09:19:14

by Varadarajan Narayanan

[permalink] [raw]
Subject: [PATCH v6 1/3] dt-bindings: thermal: tsens: Add ipq9574 compatible

From: Praveenkumar I <[email protected]>

Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.

Reviewed-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Praveenkumar I <[email protected]>
Signed-off-by: Varadarajan Narayanan <[email protected]>
---
[v5]:
Fix dt_binding_check & dtbs_check errors without removing existing entries
[v4]:
Add description about IPQ9574 and remove unnecessary
additions to the file
[v3]:
Fix dt_binding_check & dtbs_check errors (Used
Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
as reference/example)

Drop 'Acked-by: Rob Herring' as suggested in review

[v2]:
Thanks to Krzysztof Kozlowski <[email protected]>
for the tip to make qcom,ipq8074-tsens as fallback.
---
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index d1ec963..e7d0341 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -67,6 +67,12 @@ properties:
enum:
- qcom,ipq8074-tsens

+ - description: v2 of TSENS with combined interrupt
+ items:
+ - enum:
+ - qcom,ipq9574-tsens
+ - const: qcom,ipq8074-tsens
+
reg:
items:
- description: TM registers
--
2.7.4


2023-06-13 08:59:20

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH v6 1/3] dt-bindings: thermal: tsens: Add ipq9574 compatible

On 07/06/2023 10:53, Varadarajan Narayanan wrote:
> From: Praveenkumar I <[email protected]>
>
> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: Praveenkumar I <[email protected]>
> Signed-off-by: Varadarajan Narayanan <[email protected]>
> ---

Applied patch 1, thank

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


2023-06-14 00:08:57

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH v6 0/3] Enable IPQ9574 TSENS support

On Wed, 7 Jun 2023 14:23:07 +0530, Varadarajan Narayanan wrote:
> This patch set enables tsens in IPQ9574
>
> Depends on
> https://lore.kernel.org/linux-arm-msm/[email protected]/
> [v6]:
> Remove comments from tsens node in dtsi
> [v5]:
> Fix make DT_CHECKER_FLAGS=-m dt_binding_check and make dtbs_check errors without removing existing entries
>
> [...]

Applied, thanks!

[2/3] arm64: dts: qcom: ipq9574: add tsens node
commit: 2e0580e10e919b544d7be1b2b8fc48fc7dff1322
[3/3] arm64: dts: qcom: ipq9574: add thermal zone nodes
commit: 581dcbe60b6390c633f318a29db41d1df642e6d8

Best regards,
--
Bjorn Andersson <[email protected]>