2023-06-14 08:54:35

by Jiapeng Chong

Subject: [PATCH] clk: meson: pll: remove unneeded semicolon

No functional modification involved.

./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/clk/meson/clk-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
index 56ec2210f1ad..8fef90bf962f 100644
--- a/drivers/clk/meson/clk-pll.c
+++ b/drivers/clk/meson/clk-pll.c
@@ -370,7 +370,7 @@ static int meson_clk_pll_enable(struct clk_hw *hw)
usleep_range(10, 20);
meson_parm_write(clk->map, &pll->current_en, 1);
usleep_range(40, 50);
- };
+ }

if (MESON_PARM_APPLICABLE(&pll->l_detect)) {
meson_parm_write(clk->map, &pll->l_detect, 1);
--
2.20.1.7.g153144c

2023-06-14 14:40:43

by Jerome Brunet

Subject: Re: [PATCH] clk: meson: pll: remove unneeded semicolon

On Wed 14 Jun 2023 at 16:48, Jiapeng Chong <[email protected]> wrote:

> No functional modification involved.
>
> ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533

Not sure this tag is relevant

> Signed-off-by: Jiapeng Chong <[email protected]>

Apart from this

Reviewed-by: Jerome Brunet <[email protected]>

> ---
> drivers/clk/meson/clk-pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
> index 56ec2210f1ad..8fef90bf962f 100644
> --- a/drivers/clk/meson/clk-pll.c
> +++ b/drivers/clk/meson/clk-pll.c
> @@ -370,7 +370,7 @@ static int meson_clk_pll_enable(struct clk_hw *hw)
> usleep_range(10, 20);
> meson_parm_write(clk->map, &pll->current_en, 1);
> usleep_range(40, 50);
> - };
> + }
>
> if (MESON_PARM_APPLICABLE(&pll->l_detect)) {
> meson_parm_write(clk->map, &pll->l_detect, 1);

2023-06-14 20:27:25

by Martin Blumenstingl

Subject: Re: [PATCH] clk: meson: pll: remove unneeded semicolon

On Wed, Jun 14, 2023 at 10:48 AM Jiapeng Chong
<[email protected]> wrote:
>
> No functional modification involved.
>
> ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533
> Signed-off-by: Jiapeng Chong <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>

2023-06-15 10:54:01

by Jerome Brunet

Subject: Re: [PATCH] clk: meson: pll: remove unneeded semicolon

On Wed 14 Jun 2023 at 22:09, Martin Blumenstingl <[email protected]> wrote:

> On Wed, Jun 14, 2023 at 10:48 AM Jiapeng Chong
> <[email protected]> wrote:
>>
>> No functional modification involved.
>>
>> ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon.
>>
>> Reported-by: Abaci Robot <[email protected]>
>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533

Removed this bugzilla tag and added a fixes tag:
Fixes: b6ec400aa153 ("clk: meson: introduce new pll power-on sequence for A1 SoC family")

>> Signed-off-by: Jiapeng Chong <[email protected]>
> Reviewed-by: Martin Blumenstingl <[email protected]>

Applied through the amlogic clock tree.
Thx

2023-06-22 19:24:47

by Dmitry Rokosov

Subject: Re: [PATCH] clk: meson: pll: remove unneeded semicolon

Dear Jiapeng,

Thank you for catching this bug! Appreciate it!

On Wed, Jun 14, 2023 at 04:48:08PM +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5533
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/clk/meson/clk-pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
> index 56ec2210f1ad..8fef90bf962f 100644
> --- a/drivers/clk/meson/clk-pll.c
> +++ b/drivers/clk/meson/clk-pll.c
> @@ -370,7 +370,7 @@ static int meson_clk_pll_enable(struct clk_hw *hw)
> usleep_range(10, 20);
> meson_parm_write(clk->map, &pll->current_en, 1);
> usleep_range(40, 50);
> - };
> + }
>
> if (MESON_PARM_APPLICABLE(&pll->l_detect)) {
> meson_parm_write(clk->map, &pll->l_detect, 1);

Reviewed-by: Dmitry Rokosov <[email protected]>

> --
> 2.20.1.7.g153144c
>
>
> _______________________________________________
> linux-amlogic mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

--
Thank you,
Dmitry