2023-06-15 09:44:42

by Anvesh Jain P

Subject: [PATCH] iommu: export iommu_set_default_translated function

export iommu_set_default_translated function to be used by other modules.

Signed-off-by: Anvesh Jain P <[email protected]>
Signed-off-by: Venkata Rao Kakani <[email protected]>
Signed-off-by: Vagdhan Kumar <[email protected]>
---
drivers/iommu/iommu.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index f1dcfa3f1a1b..1b4a5db58d66 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -2730,6 +2730,7 @@ void iommu_set_default_translated(bool cmd_line)
iommu_cmd_line |= IOMMU_CMD_LINE_DMA_API;
iommu_def_domain_type = IOMMU_DOMAIN_DMA;
}
+EXPORT_SYMBOL_GPL(iommu_set_default_translated);

bool iommu_default_passthrough(void)
{

base-commit: b6dad5178ceaf23f369c3711062ce1f2afc33644
--
2.17.1

2023-06-15 09:57:30

by Robin Murphy

Subject: Re: [PATCH] iommu: export iommu_set_default_translated function

On 2023-06-15 10:33, Anvesh Jain P wrote:
> export iommu_set_default_translated function to be used by other modules.

Which modules? The only reason these functions are public at all is to
support the legacy x86 command-line options. No *new* code outside the
core API should have any reason to be messing with core API policy. If
an IOMMU driver needs to special-case particular devices we have
.def_domain_type for that.

Thanks,
Robin.

> Signed-off-by: Anvesh Jain P <[email protected]>
> Signed-off-by: Venkata Rao Kakani <[email protected]>
> Signed-off-by: Vagdhan Kumar <[email protected]>
> ---
> drivers/iommu/iommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index f1dcfa3f1a1b..1b4a5db58d66 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -2730,6 +2730,7 @@ void iommu_set_default_translated(bool cmd_line)
> iommu_cmd_line |= IOMMU_CMD_LINE_DMA_API;
> iommu_def_domain_type = IOMMU_DOMAIN_DMA;
> }
> +EXPORT_SYMBOL_GPL(iommu_set_default_translated);
>
> bool iommu_default_passthrough(void)
> {
>
> base-commit: b6dad5178ceaf23f369c3711062ce1f2afc33644

2023-06-16 02:26:13

by Lu Baolu

Subject: Re: [PATCH] iommu: export iommu_set_default_translated function

On 6/15/23 5:33 PM, Anvesh Jain P wrote:
> export iommu_set_default_translated function to be used by other modules.
>
> Signed-off-by: Anvesh Jain P <[email protected]>
> Signed-off-by: Venkata Rao Kakani <[email protected]>
> Signed-off-by: Vagdhan Kumar <[email protected]>
> ---
> drivers/iommu/iommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index f1dcfa3f1a1b..1b4a5db58d66 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -2730,6 +2730,7 @@ void iommu_set_default_translated(bool cmd_line)
> iommu_cmd_line |= IOMMU_CMD_LINE_DMA_API;
> iommu_def_domain_type = IOMMU_DOMAIN_DMA;
> }
> +EXPORT_SYMBOL_GPL(iommu_set_default_translated);

Exporting a symbol without using it is meaningless. It is better to
export and use it in a single series.

Additionally, there is a restriction on the use of this helper. Calling
it after the iommu probe has no effect.

>
> bool iommu_default_passthrough(void)
> {
>
> base-commit: b6dad5178ceaf23f369c3711062ce1f2afc33644

Best regards,
baolu