2023-07-02 12:56:37

by Yogesh Hegde

[permalink] [raw]
Subject: [PATCH 0/4] Trivial code cleanup patches

Rename variables in function _rtl92e_dm_check_rate_adaptive
to avoid checkpatch complains.

The patches are required to be applied in sequence.

Yogesh Hegde (4):
staging: rtl8192e: Rename variable currentRATR
staging: rtl8192e: Rename variable targetRATR
staging: rtl8192e: Rename variable LowRSSIThreshForRA
staging: rtl8192e: Rename variable HighRSSIThreshForRA

drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 38 +++++++++++-----------
1 file changed, 19 insertions(+), 19 deletions(-)

--
2.34.1



2023-07-02 13:10:08

by Yogesh Hegde

[permalink] [raw]
Subject: [PATCH 1/4] staging: rtl8192e: Rename variable currentRATR

Rename variable currentRATR to current_ratr to avoid CamelCase
which is not accepted by checkpatch.

Signed-off-by: Yogesh Hegde <[email protected]>
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index 37c275cac40b..14c78f740366 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -277,7 +277,7 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev)
struct r8192_priv *priv = rtllib_priv(dev);
struct rt_hi_throughput *ht_info = priv->rtllib->ht_info;
struct rate_adaptive *pra = &priv->rate_adaptive;
- u32 currentRATR, targetRATR = 0;
+ u32 current_ratr, targetRATR = 0;
u32 LowRSSIThreshForRA = 0, HighRSSIThreshForRA = 0;
bool bshort_gi_enabled = false;
static u8 ping_rssi_state;
@@ -363,8 +363,8 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev)
if (priv->rtllib->GetHalfNmodeSupportByAPsHandler(dev))
targetRATR &= 0xf00fffff;

- currentRATR = rtl92e_readl(dev, RATR0);
- if (targetRATR != currentRATR) {
+ current_ratr = rtl92e_readl(dev, RATR0);
+ if (targetRATR != current_ratr) {
u32 ratr_value;

ratr_value = targetRATR;
--
2.34.1


2023-07-02 13:33:01

by Yogesh Hegde

[permalink] [raw]
Subject: [PATCH 4/4] staging: rtl8192e: Rename variable HighRSSIThreshForRA

Rename variable HighRSSIThreshForRA to high_rssi_thresh_for_ra to avoid
CamelCase which is not accepted by checkpatch.

Signed-off-by: Yogesh Hegde <[email protected]>
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index d266d2d047ca..dbf765d601b3 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -278,7 +278,7 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev)
struct rt_hi_throughput *ht_info = priv->rtllib->ht_info;
struct rate_adaptive *pra = &priv->rate_adaptive;
u32 current_ratr, target_ratr = 0;
- u32 low_rssi_thresh_for_ra = 0, HighRSSIThreshForRA = 0;
+ u32 low_rssi_thresh_for_ra = 0, high_rssi_thresh_for_ra = 0;
bool bshort_gi_enabled = false;
static u8 ping_rssi_state;

@@ -319,21 +319,21 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev)
((bshort_gi_enabled) ? BIT31 : 0);

if (pra->ratr_state == DM_RATR_STA_HIGH) {
- HighRSSIThreshForRA = pra->high2low_rssi_thresh_for_ra;
+ high_rssi_thresh_for_ra = pra->high2low_rssi_thresh_for_ra;
low_rssi_thresh_for_ra = (priv->current_chnl_bw != HT_CHANNEL_WIDTH_20) ?
(pra->low_rssi_thresh_for_ra40M) : (pra->low_rssi_thresh_for_ra20M);
} else if (pra->ratr_state == DM_RATR_STA_LOW) {
- HighRSSIThreshForRA = pra->high_rssi_thresh_for_ra;
+ high_rssi_thresh_for_ra = pra->high_rssi_thresh_for_ra;
low_rssi_thresh_for_ra = (priv->current_chnl_bw != HT_CHANNEL_WIDTH_20) ?
(pra->low2high_rssi_thresh_for_ra40M) : (pra->low2high_rssi_thresh_for_ra20M);
} else {
- HighRSSIThreshForRA = pra->high_rssi_thresh_for_ra;
+ high_rssi_thresh_for_ra = pra->high_rssi_thresh_for_ra;
low_rssi_thresh_for_ra = (priv->current_chnl_bw != HT_CHANNEL_WIDTH_20) ?
(pra->low_rssi_thresh_for_ra40M) : (pra->low_rssi_thresh_for_ra20M);
}

if (priv->undecorated_smoothed_pwdb >=
- (long)HighRSSIThreshForRA) {
+ (long)high_rssi_thresh_for_ra) {
pra->ratr_state = DM_RATR_STA_HIGH;
target_ratr = pra->upper_rssi_threshold_ratr;
} else if (priv->undecorated_smoothed_pwdb >=
--
2.34.1


2023-07-06 15:48:38

by Philipp Hortmann

[permalink] [raw]
Subject: Re: [PATCH 0/4] Trivial code cleanup patches

On 7/2/23 14:14, Yogesh Hegde wrote:
> Rename variables in function _rtl92e_dm_check_rate_adaptive
> to avoid checkpatch complains.
>
> The patches are required to be applied in sequence.
>
> Yogesh Hegde (4):
> staging: rtl8192e: Rename variable currentRATR
> staging: rtl8192e: Rename variable targetRATR
> staging: rtl8192e: Rename variable LowRSSIThreshForRA
> staging: rtl8192e: Rename variable HighRSSIThreshForRA
>
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 38 +++++++++++-----------
> 1 file changed, 19 insertions(+), 19 deletions(-)
>

Please use the "staging: rtl8192e:" also for the cover letter in the
subject for the next patch series you are sending.



Tested-by: Philipp Hortmann <[email protected]>



2023-07-08 06:55:13

by Yogesh Hegde

[permalink] [raw]
Subject: Re: [PATCH 0/4] Trivial code cleanup patches

On Thu, Jul 06, 2023 at 05:30:27PM +0200, Philipp Hortmann wrote:
> On 7/2/23 14:14, Yogesh Hegde wrote:
> > Rename variables in function _rtl92e_dm_check_rate_adaptive
> > to avoid checkpatch complains.
> >
> > The patches are required to be applied in sequence.
> >
> > Yogesh Hegde (4):
> > staging: rtl8192e: Rename variable currentRATR
> > staging: rtl8192e: Rename variable targetRATR
> > staging: rtl8192e: Rename variable LowRSSIThreshForRA
> > staging: rtl8192e: Rename variable HighRSSIThreshForRA
> >
> > drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 38 +++++++++++-----------
> > 1 file changed, 19 insertions(+), 19 deletions(-)
> >
>
> Please use the "staging: rtl8192e:" also for the cover letter in the subject
> for the next patch series you are sending.
Ack. Will keep in mind for next patch series.
>
>
> Tested-by: Philipp Hortmann <[email protected]>

Thanks
Yogesh