2023-07-05 15:06:00

by Wang Ming

[permalink] [raw]
Subject: [PATCH v1] intel_th:Fix repeated initialization

In intel_th_set_output() function,
the second assignment to hubdrv is
meaningless.

Signed-off-by: Wang Ming <[email protected]>
---
drivers/hwtracing/intel_th/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c
index cc7f879bb175..804c2f27b159 100644
--- a/drivers/hwtracing/intel_th/core.c
+++ b/drivers/hwtracing/intel_th/core.c
@@ -1048,7 +1048,7 @@ int intel_th_set_output(struct intel_th_device *thdev,
* hub is instantiated together with the source device that
* calls here, so guaranteed to be present.
*/
- hubdrv = to_intel_th_driver(hub->dev.driver);
+
if (!hubdrv || !try_module_get(hubdrv->driver.owner))
return -EINVAL;

--
2.25.1