2023-07-12 10:14:37

by Bartosz Golaszewski

Subject: [PATCH] gpiolib: order includes alphabetically in gpiolib.h

From: Bartosz Golaszewski <[email protected]>

After adding the missing notifier.h header, let's order all includes
alphabetically.

Suggested-by: Andy Shevchenko <[email protected]>
Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/gpio/gpiolib.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
index 1409d52487c0..7c562fbb9fb0 100644
--- a/drivers/gpio/gpiolib.h
+++ b/drivers/gpio/gpiolib.h
@@ -9,13 +9,13 @@
#ifndef GPIOLIB_H
#define GPIOLIB_H

-#include <linux/gpio/driver.h>
-#include <linux/gpio/consumer.h> /* for enum gpiod_flags */
-#include <linux/err.h>
+#include <linux/cdev.h>
#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/gpio/consumer.h> /* for enum gpiod_flags */
+#include <linux/gpio/driver.h>
#include <linux/module.h>
#include <linux/notifier.h>
-#include <linux/cdev.h>
#include <linux/rwsem.h>

#define GPIOCHIP_NAME "gpiochip"
--
2.39.2

2023-07-12 16:04:29

by Andy Shevchenko

Subject: Re: [PATCH] gpiolib: order includes alphabetically in gpiolib.h

On Wed, Jul 12, 2023 at 11:59:55AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> After adding the missing notifier.h header, let's order all includes
> alphabetically.

Reviewed-by: Andy Shevchenko <[email protected]>

--
With Best Regards,
Andy Shevchenko

2023-07-20 20:06:29

by Linus Walleij

Subject: Re: [PATCH] gpiolib: order includes alphabetically in gpiolib.h

On Wed, Jul 12, 2023 at 11:59 AM Bartosz Golaszewski <[email protected]> wrote:

> From: Bartosz Golaszewski <[email protected]>
>
> After adding the missing notifier.h header, let's order all includes
> alphabetically.
>
> Suggested-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij