2023-07-20 03:00:00

by Yonggang Wu

Subject: [PATCH] tracing: add missing spaces after ';'

Remove spaces to clear checkpatch errors.

ERROR: space required after that ';' (ctx:VxV)

Signed-off-by: Yonggang Wu <[email protected]>
---
include/trace/stages/stage4_event_fields.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/stages/stage4_event_fields.h
b/include/trace/stages/stage4_event_fields.h
index b6f679ae21aa..9627e081a990 100644
--- a/include/trace/stages/stage4_event_fields.h
+++ b/include/trace/stages/stage4_event_fields.h
@@ -2,7 +2,7 @@

/* Stage 4 definitions for creating trace events */

-#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b;})))
+#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b; })))

#undef __field_ext
#define __field_ext(_type, _item, _filter_type) { \

2023-07-20 17:58:27

by Steven Rostedt

Subject: Re: [PATCH] tracing: add missing spaces after ';'

On Thu, 20 Jul 2023 10:30:36 +0800
[email protected] wrote:

> Remove spaces to clear checkpatch errors.
>
> ERROR: space required after that ';' (ctx:VxV)

PLEASE DO NOT RUN CHECKPATCH ON CURRENT CODE!!!!

As the name suggests, checkpatch is for patches and not for existing code.
It is used as a guideline tool to make clean patches. But checkpatch is
*NOT* the rule of the kernel. There's lots of issues that checkpatch
reports that can be ignored. That is decided when the patch is submitted,
and SHOULD NOT be revisited once it has been accepted. Not to mention this
particular error is silly.

NACK!!!

-- Steve

>
> Signed-off-by: Yonggang Wu <[email protected]>
> ---
> include/trace/stages/stage4_event_fields.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/stages/stage4_event_fields.h
> b/include/trace/stages/stage4_event_fields.h
> index b6f679ae21aa..9627e081a990 100644
> --- a/include/trace/stages/stage4_event_fields.h
> +++ b/include/trace/stages/stage4_event_fields.h
> @@ -2,7 +2,7 @@
>
> /* Stage 4 definitions for creating trace events */
>
> -#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b;})))
> +#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b; })))
>
> #undef __field_ext
> #define __field_ext(_type, _item, _filter_type) { \