2023-07-26 11:41:10

by werneazc

Subject: [PATCH] hwmon: (hs3001) Fix unused variable compiler warning

From: Andre Werner <[email protected]>

Delete unused variable in drivers probe function.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Signed-off-by: Andre Werner <[email protected]>
---
---
drivers/hwmon/hs3001.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/hwmon/hs3001.c b/drivers/hwmon/hs3001.c
index 17c3455922eb..9972f6bbb22a 100644
--- a/drivers/hwmon/hs3001.c
+++ b/drivers/hwmon/hs3001.c
@@ -193,7 +193,6 @@ static int hs3001_probe(struct i2c_client *client)
struct hs3001_data *data;
struct device *hwmon_dev;
struct device *dev = &client->dev;
- int ret;

if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
return -EOPNOTSUPP;
--
2.41.0

2023-07-26 12:43:09

by Krzysztof Kozlowski

Subject: Re: [PATCH] hwmon: (hs3001) Fix unused variable compiler warning

On 26/07/2023 14:20, Krzysztof Kozlowski wrote:
> On 26/07/2023 13:36, [email protected] wrote:
>> From: Andre Werner <[email protected]>
>>
>> Delete unused variable in drivers probe function.
>>
>> Reported-by: kernel test robot <[email protected]>
>> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>>
> No blank lines between the tags.
>
>> Signed-off-by: Andre Werner <[email protected]>
>
> Was the original patch actually merged? I don't see it in next.

Ah, I see Guenter's response.

Best regards,
Krzysztof

2023-07-26 12:47:33

by Krzysztof Kozlowski

Subject: Re: [PATCH] hwmon: (hs3001) Fix unused variable compiler warning

On 26/07/2023 13:36, [email protected] wrote:
> From: Andre Werner <[email protected]>
>
> Delete unused variable in drivers probe function.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
No blank lines between the tags.

> Signed-off-by: Andre Werner <[email protected]>

Was the original patch actually merged? I don't see it in next.


Best regards,
Krzysztof

2023-07-26 14:06:03

by werneazc

Subject: [PATCH v2] hwmon: (hs3001) Fix unused variable compiler warning

From: Andre Werner <[email protected]>

Delete unused variable in drivers probe function.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Andre Werner <[email protected]>
---
v2: Delete blank line between tags in commit message.
---
drivers/hwmon/hs3001.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/hwmon/hs3001.c b/drivers/hwmon/hs3001.c
index 17c3455922eb..9972f6bbb22a 100644
--- a/drivers/hwmon/hs3001.c
+++ b/drivers/hwmon/hs3001.c
@@ -193,7 +193,6 @@ static int hs3001_probe(struct i2c_client *client)
struct hs3001_data *data;
struct device *hwmon_dev;
struct device *dev = &client->dev;
- int ret;

if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
return -EOPNOTSUPP;
--
2.41.0

2023-07-26 14:37:38

by Guenter Roeck

Subject: Re: [PATCH v2] hwmon: (hs3001) Fix unused variable compiler warning

On Wed, Jul 26, 2023 at 03:06:02PM +0200, [email protected] wrote:
> From: Andre Werner <[email protected]>
>
> Delete unused variable in drivers probe function.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Andre Werner <[email protected]>

Applied.

Thanks,
Guenter

> ---
> v2: Delete blank line between tags in commit message.
> ---
> drivers/hwmon/hs3001.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwmon/hs3001.c b/drivers/hwmon/hs3001.c
> index 17c3455922eb..9972f6bbb22a 100644
> --- a/drivers/hwmon/hs3001.c
> +++ b/drivers/hwmon/hs3001.c
> @@ -193,7 +193,6 @@ static int hs3001_probe(struct i2c_client *client)
> struct hs3001_data *data;
> struct device *hwmon_dev;
> struct device *dev = &client->dev;
> - int ret;
>
> if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
> return -EOPNOTSUPP;