2023-08-03 15:11:28

by Arnd Bergmann

Subject: [PATCH] rcu: include torture_sched_setaffinity() declaration

From: Arnd Bergmann <[email protected]>

The prototype for torture_sched_setaffinity() moved to a
different header, which needs to be included from update.c
to avoid this W=1 warning:

kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)

Fixes: 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
Signed-off-by: Arnd Bergmann <[email protected]>
---
kernel/rcu/update.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
index 0533b510f0a8..c534d6806d3d 100644
--- a/kernel/rcu/update.c
+++ b/kernel/rcu/update.c
@@ -25,6 +25,7 @@
#include <linux/interrupt.h>
#include <linux/sched/signal.h>
#include <linux/sched/debug.h>
+#include <linux/torture.h>
#include <linux/atomic.h>
#include <linux/bitops.h>
#include <linux/percpu.h>
--
2.39.2

2023-08-03 16:41:29

by Paul E. McKenney

Subject: Re: [PATCH] rcu: include torture_sched_setaffinity() declaration

On Thu, Aug 03, 2023 at 12:02:52PM -0400, Joel Fernandes wrote:
> On Thu, Aug 3, 2023 at 10:40 AM Arnd Bergmann <[email protected]> wrote:
> >
> > From: Arnd Bergmann <[email protected]>
> >
> > The prototype for torture_sched_setaffinity() moved to a
> > different header, which needs to be included from update.c
> > to avoid this W=1 warning:
> >
> > kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
> > 529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)
> >
> > Fixes: 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
> > Signed-off-by: Arnd Bergmann <[email protected]>
>
> Reviewed-by: Joel Fernandes (Google) <[email protected]>

Queued (likely for the v6.7 merge window), thank you both!

Thanx, Paul

> thanks,
>
> - Joel
>
>
> > ---
> > kernel/rcu/update.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
> > index 0533b510f0a8..c534d6806d3d 100644
> > --- a/kernel/rcu/update.c
> > +++ b/kernel/rcu/update.c
> > @@ -25,6 +25,7 @@
> > #include <linux/interrupt.h>
> > #include <linux/sched/signal.h>
> > #include <linux/sched/debug.h>
> > +#include <linux/torture.h>
> > #include <linux/atomic.h>
> > #include <linux/bitops.h>
> > #include <linux/percpu.h>
> > --
> > 2.39.2
> >

2023-08-03 16:56:57

by Joel Fernandes

Subject: Re: [PATCH] rcu: include torture_sched_setaffinity() declaration

On Thu, Aug 3, 2023 at 10:40 AM Arnd Bergmann <[email protected]> wrote:
>
> From: Arnd Bergmann <[email protected]>
>
> The prototype for torture_sched_setaffinity() moved to a
> different header, which needs to be included from update.c
> to avoid this W=1 warning:
>
> kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
> 529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)
>
> Fixes: 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
> Signed-off-by: Arnd Bergmann <[email protected]>

Reviewed-by: Joel Fernandes (Google) <[email protected]>

thanks,

- Joel


> ---
> kernel/rcu/update.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
> index 0533b510f0a8..c534d6806d3d 100644
> --- a/kernel/rcu/update.c
> +++ b/kernel/rcu/update.c
> @@ -25,6 +25,7 @@
> #include <linux/interrupt.h>
> #include <linux/sched/signal.h>
> #include <linux/sched/debug.h>
> +#include <linux/torture.h>
> #include <linux/atomic.h>
> #include <linux/bitops.h>
> #include <linux/percpu.h>
> --
> 2.39.2
>