2023-08-08 18:56:56

by Dhruva Gole

[permalink] [raw]
Subject: [PATCH 0/2] pinctrl-single: introduce am654-padconf compatible

The K3 family of SOCs use certain bits of the padconfig registers like
WKUP_EVT and WKUP_EN to enable daisychain wakeups.

For example, these bits are described in the AM654 TRM [0] under
"Table 5-517. Description Of The Pad Configuration Register Bits"

This series adds the DT binding changes for adding the compatible and
also the driver changes which make use of this compatible.

NOTE: Some K3 SoCs may have these bits marked as reserved which means
that they don't support IO daisychain. Such SOCs are not expected to use
this compatible.

The general expected usage is when the device is in a suspended state like Deep
Sleep or Suspend to RAM, and any IO activity on configured pads can
trigger a wakeup.

Link to complete series:
https://lore.kernel.org/all/[email protected]

Base commit:
71cd4fc492ec (tag: next-20230808, linux-next/master) Add linux-next specific files for 20230808

depends on:
https://lore.kernel.org/r/[email protected]

which has been picked up by Linus Walleij in his tree here:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=devel&id=677a62482bd6e584f83d0342e78735e3cd449ba4

However, it hasn't reflected in -next yet so specifying the depends on
above.

[0] https://www.ti.com/lit/pdf/spruid7

Cc: Nishanth Menon <[email protected]>
Cc: Vignesh Raghavendra <[email protected]>
Cc: Tony Lindgren <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Haojian Zhuang <[email protected]>

Dhruva Gole (1):
dt-bindings: pinctrl: pinctrl-single: add ti,am654-padconf compatible

Tony Lindgren (1):
pinctrl: single: Add compatible for ti,am654-padconf

.../devicetree/bindings/pinctrl/pinctrl-single.yaml | 1 +
drivers/pinctrl/pinctrl-single.c | 7 +++++++
2 files changed, 8 insertions(+)

--
2.34.1



2023-08-08 20:34:04

by Dhruva Gole

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: pinctrl: pinctrl-single: add ti,am654-padconf compatible

Add the "ti,am654-padconf" compatible to support the new wakeup enable and
status bits positions on K3 family SOCs that support the IO daisychain
feature.

Signed-off-by: Dhruva Gole <[email protected]>
---

Previously, this was posted here:
https://lore.kernel.org/all/[email protected]/

However since then I have tweaked the commit message and also the name
of compatible. Hence didn't pickup the Acked-by: Conor and Tony's R-by:
https://lore.kernel.org/all/[email protected]/

Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
index b6b6bcd7074b..45a307d3ce16 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
@@ -24,6 +24,7 @@ properties:
- items:
- enum:
- ti,am437-padconf
+ - ti,am654-padconf
- ti,dra7-padconf
- ti,omap2420-padconf
- ti,omap2430-padconf
--
2.34.1


2023-08-09 12:59:48

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH 0/2] pinctrl-single: introduce am654-padconf compatible

On 15:52-20230808, Dhruva Gole wrote:
> The K3 family of SOCs use certain bits of the padconfig registers like
> WKUP_EVT and WKUP_EN to enable daisychain wakeups.
>
> For example, these bits are described in the AM654 TRM [0] under
> "Table 5-517. Description Of The Pad Configuration Register Bits"
>
> This series adds the DT binding changes for adding the compatible and
> also the driver changes which make use of this compatible.
>
> NOTE: Some K3 SoCs may have these bits marked as reserved which means
> that they don't support IO daisychain. Such SOCs are not expected to use
> this compatible.
>
> The general expected usage is when the device is in a suspended state like Deep
> Sleep or Suspend to RAM, and any IO activity on configured pads can
> trigger a wakeup.
>
> Link to complete series:
> https://lore.kernel.org/all/[email protected]
>
> Base commit:
> 71cd4fc492ec (tag: next-20230808, linux-next/master) Add linux-next specific files for 20230808
>
> depends on:
> https://lore.kernel.org/r/[email protected]
>
> which has been picked up by Linus Walleij in his tree here:
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=devel&id=677a62482bd6e584f83d0342e78735e3cd449ba4
>
> However, it hasn't reflected in -next yet so specifying the depends on
> above.

next-20230809 has it today - so just a day or two of sync.. no biggie.

>
> [0] https://www.ti.com/lit/pdf/spruid7
>
> Cc: Nishanth Menon <[email protected]>
> Cc: Vignesh Raghavendra <[email protected]>
> Cc: Tony Lindgren <[email protected]>
> Cc: Conor Dooley <[email protected]>
> Cc: Krzysztof Kozlowski <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Haojian Zhuang <[email protected]>

For the series:

Reviewed-by: Nishanth Menon <[email protected]>

Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2023-08-10 09:00:55

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: pinctrl-single: add ti,am654-padconf compatible

On Tue, Aug 8, 2023 at 12:24 PM Dhruva Gole <[email protected]> wrote:

> Add the "ti,am654-padconf" compatible to support the new wakeup enable and
> status bits positions on K3 family SOCs that support the IO daisychain
> feature.
>
> Signed-off-by: Dhruva Gole <[email protected]>

Patch applied.

Yours,
Linus Walleij