2023-08-09 07:02:24

by Ratheesh Kannoth

Subject: [PATCH net-next] octeontx2-af: Harden rule validation.

Accept TC offload classifier rule only if SPI field
can be extracted by HW.

Signed-off-by: Ratheesh Kannoth <[email protected]>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
index 5c8f9fc15ff8..237f82082ebe 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
@@ -580,7 +580,9 @@ static void npc_set_features(struct rvu *rvu, int blkaddr, u8 intf)
if (!npc_check_field(rvu, blkaddr, NPC_LB, intf))
*features &= ~BIT_ULL(NPC_OUTER_VID);

- if (*features & (BIT_ULL(NPC_IPPROTO_AH) | BIT_ULL(NPC_IPPROTO_ESP)))
+ /* Set SPI flag only if AH/ESP and IPSEC_SPI are in the key */
+ if (npc_check_field(rvu, blkaddr, NPC_IPSEC_SPI, intf) &&
+ (*features & (BIT_ULL(NPC_IPPROTO_ESP) | BIT_ULL(NPC_IPPROTO_AH))))
*features |= BIT_ULL(NPC_IPSEC_SPI);

/* for vlan ethertypes corresponding layer type should be in the key */
--
2.25.1

2023-08-10 15:10:58

by Simon Horman

Subject: Re: [PATCH net-next] octeontx2-af: Harden rule validation.

On Wed, Aug 09, 2023 at 12:10:39PM +0530, Ratheesh Kannoth wrote:
> Accept TC offload classifier rule only if SPI field
> can be extracted by HW.
>
> Signed-off-by: Ratheesh Kannoth <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2023-08-11 09:01:56

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] octeontx2-af: Harden rule validation.

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Wed, 9 Aug 2023 12:10:39 +0530 you wrote:
> Accept TC offload classifier rule only if SPI field
> can be extracted by HW.
>
> Signed-off-by: Ratheesh Kannoth <[email protected]>
> ---
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Here is the summary with links:
- [net-next] octeontx2-af: Harden rule validation.
https://git.kernel.org/netdev/net-next/c/12aa0a3b93f3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html