2023-08-09 10:17:41

by Mia Lin

Subject: [PATCH v2 0/2] Compatible with NCT3015Y-R and NCT3018Y-R

Changes since version 2:
Add DT compatible to check the chip matches or not.

Changes since version 1:
rtc: nuvoton: Compatible with NCT3015Y-R and NCT3018Y-R

Mia Lin (2):
dt-bindings: rtc: nuvoton: Add DT compatible
rtc: nuvoton: Compatible with NCT3015Y-R and NCT3018Y-R

.../bindings/rtc/nuvoton,nct3018y.yaml | 4 +-
drivers/rtc/rtc-nct3018y.c | 88 ++++++++++++++++---
2 files changed, 81 insertions(+), 11 deletions(-)

--
2.17.1

2023-08-09 11:49:21

by Mia Lin

Subject: [PATCH v2 1/2] dt-bindings: rtc: nuvoton: Add DT compatible

Add DT compatible "nuvoton,nct3015y" to select

Signed-off-by: Mia Lin <[email protected]>
---
Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
index 4f9b5604acd9..67fc60fd395c 100644
--- a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
+++ b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
@@ -15,7 +15,9 @@ maintainers:

properties:
compatible:
- const: nuvoton,nct3018y
+ enum:
+ - nuvoton,nct3018y
+ - nuvoton,nct3015y

reg:
maxItems: 1
--
2.17.1

2023-08-09 15:18:34

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/2] dt-bindings: rtc: nuvoton: Add DT compatible

On 09/08/2023 11:51, Mia Lin wrote:
> Add DT compatible "nuvoton,nct3015y" to select
>
> Signed-off-by: Mia Lin <[email protected]>
> ---
> Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
> index 4f9b5604acd9..67fc60fd395c 100644
> --- a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
> @@ -15,7 +15,9 @@ maintainers:
>
> properties:
> compatible:
> - const: nuvoton,nct3018y
> + enum:
> + - nuvoton,nct3018y
> + - nuvoton,nct3015y

Responding here, but based on your changelog and driver:
Why? Why do you need compatibles to verify the reported ID? Verifying ID
does not make sense. At all.

These are compatible devices, so you could have one more compatible
using old one as fallback. And no new entry in the driver.

Best regards,
Krzysztof

2023-08-10 08:13:09

by Paul Menzel

Subject: Re: [PATCH v2 1/2] dt-bindings: rtc: nuvoton: Add DT compatible

Dear Mia,


Thank you for your patch. It’d be great if you mentioned nct3015y in the
commit message summary/title. Maybe:

dt-bindings: rtc: Add compatible nct3015y to nuvoton,nct3018y

Am 09.08.23 um 11:51 schrieb Mia Lin:
> Add DT compatible "nuvoton,nct3015y" to select

What do you mean by “to select”?

Also, maybe add how you tested this.

> Signed-off-by: Mia Lin <[email protected]>
> ---
> Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
> index 4f9b5604acd9..67fc60fd395c 100644
> --- a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
> @@ -15,7 +15,9 @@ maintainers:
>
> properties:
> compatible:
> - const: nuvoton,nct3018y
> + enum:
> + - nuvoton,nct3018y
> + - nuvoton,nct3015y

Would sorting the list be useful?

> reg:
> maxItems: 1


Kind regards,

Paul