IPQ5332 has UNIPHY for USB and PCIe which is similar to the UNIPHY
present in IPQ4019. Few extra settings like clock, reset delay, mux
selection and voltage regulator are required for IPQ5332. Hence
repurposed the IPQ4019 PHY driver for IPQ5332 UNIPHY. Few more Qualcomm
SoCs are also having the UNIPHY which can use the same driver for both
USB and PCIe PHY.
Praveenkumar I (9):
dt-bindings: phy: qcom,uniphy: Rename ipq4019 usb PHY to UNIPHY
phy: qcom: uniphy: Rename ipq4019 USB phy driver to UNIPHY driver
phy: qcom: uniphy: Update UNIPHY driver to be a common driver
dt-bindings: phy: qcom,uniphy: Add ipq5332 USB3 SS UNIPHY
dt-bindings: usb: dwc3: Update IPQ5332 compatible
arm64: dts: qcom: ipq5332: Add USB3 related nodes
arm64: dts: qcom: ipq5332: Enable USB SS UNIPHY
phy: qcom: uniphy: Add ipq5332 USB UNIPHY support
arm64: defconfig: Enable UNIPHY driver
.../devicetree/bindings/phy/qcom,uniphy.yaml | 168 +++++++
.../bindings/phy/qcom-usb-ipq4019-phy.yaml | 52 --
.../devicetree/bindings/usb/qcom,dwc3.yaml | 20 +-
MAINTAINERS | 7 +-
arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 7 +-
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 39 +-
arch/arm64/configs/defconfig | 1 +
drivers/phy/qualcomm/Kconfig | 7 +-
drivers/phy/qualcomm/Makefile | 2 +-
drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c | 145 ------
drivers/phy/qualcomm/phy-qcom-uniphy.c | 451 ++++++++++++++++++
11 files changed, 686 insertions(+), 213 deletions(-)
create mode 100644 Documentation/devicetree/bindings/phy/qcom,uniphy.yaml
delete mode 100644 Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml
delete mode 100644 drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c
create mode 100644 drivers/phy/qualcomm/phy-qcom-uniphy.c
--
2.34.1
On 8/29/2023 10:37 PM, Krzysztof Kozlowski wrote:
> On 29/08/2023 15:58, Praveenkumar I wrote:
>> IPQ5332 has UNIPHY for USB and PCIe which is similar to the UNIPHY
>> present in IPQ4019. Few extra settings like clock, reset delay, mux
>> selection and voltage regulator are required for IPQ5332. Hence
>> repurposed the IPQ4019 PHY driver for IPQ5332 UNIPHY. Few more Qualcomm
>> SoCs are also having the UNIPHY which can use the same driver for both
>> USB and PCIe PHY.
>>
>> Praveenkumar I (9):
>> dt-bindings: phy: qcom,uniphy: Rename ipq4019 usb PHY to UNIPHY
>> phy: qcom: uniphy: Rename ipq4019 USB phy driver to UNIPHY driver
>> phy: qcom: uniphy: Update UNIPHY driver to be a common driver
>> dt-bindings: phy: qcom,uniphy: Add ipq5332 USB3 SS UNIPHY
>> dt-bindings: usb: dwc3: Update IPQ5332 compatible
>> arm64: dts: qcom: ipq5332: Add USB3 related nodes
>> arm64: dts: qcom: ipq5332: Enable USB SS UNIPHY
> DTS does not go before drivers. DTS should be sent separately or as the
> last patches. If you stuff it in the middle, means your patchset has
> dependencies which it cannot have. Thus it is broken.
Sorry, I ordered it wrongly. Will correct in the next patches.
- Praveenkumar
>
> Best regards,
> Krzysztof
>