Hi Kalle,
Patch v4 (https://patchwork.kernel.org/project/linux-wireless/patch/PA4PR04MB963838F12BADC1B9FD377CB7D114A@PA4PR04MB9638.eurprd04.prod.outlook.com/) for host mlme had been submitted for a while.
Current state of this patch is "Deferred". I wonder when can this patch be reviewed and merged.
Is there anything I can do to speed up the acceptance of this patch by upstream?
Best Regards,
David
> From: David Lin
> Sent: Tuesday, August 15, 2023 3:09 PM
> To: '[email protected]' <[email protected]>
> Cc: '[email protected]' <[email protected]>;
> '[email protected]' <[email protected]>;
> '[email protected]' <[email protected]>; '[email protected]'
> <[email protected]>; '[email protected]' <[email protected]>;
> '[email protected]' <[email protected]>;
> '[email protected]' <[email protected]>;
> '[email protected]' <[email protected]>;
> '[email protected]' <[email protected]>; '[email protected]'
> <[email protected]>; 'kuba@kernelorg' <kuba@kernelorg>;
> '[email protected]' <[email protected]>
> Subject: [PATCH v4 0/1] Patch History
>
> Patch v4:
>
> 1. Correct one bad code segment.
> 2. Add code to check firmware key api version for host_mlme.
>
> Patch v3:
>
> Clean and clear commit message.
>
> Patch v2:
>
> 1. Checkpatch error: pwe[1] -> pwe[0].
> 2. Remove module parameter 'host_mlme'.
> 3. Won't advertise NL80211_FEATURE_SAE if host mlme is disabled.
>
> David Lin (1):
> wifi: mwifiex: added code to support host mlme.
>
> .../net/wireless/marvell/mwifiex/cfg80211.c | 327 ++++++++++++++++++
> drivers/net/wireless/marvell/mwifiex/cmdevt.c | 14 +-
> drivers/net/wireless/marvell/mwifiex/decl.h | 12 +
> drivers/net/wireless/marvell/mwifiex/fw.h | 15 +
> drivers/net/wireless/marvell/mwifiex/init.c | 3 +
> drivers/net/wireless/marvell/mwifiex/join.c | 64 +++-
> drivers/net/wireless/marvell/mwifiex/main.h | 10 +
> drivers/net/wireless/marvell/mwifiex/scan.c | 6 +
> drivers/net/wireless/marvell/mwifiex/sdio.c | 13 +
> drivers/net/wireless/marvell/mwifiex/sdio.h | 2 +
> .../net/wireless/marvell/mwifiex/sta_event.c | 18 +-
> .../net/wireless/marvell/mwifiex/sta_ioctl.c | 3 +-
> drivers/net/wireless/marvell/mwifiex/sta_tx.c | 10 +-
> .../net/wireless/marvell/mwifiex/uap_cmd.c | 26 ++
> drivers/net/wireless/marvell/mwifiex/util.c | 73 ++++
> 15 files changed, 583 insertions(+), 13 deletions(-)
>
> --
> 2.25.1
On Wed, Sep 13, 2023 at 11:42 PM David Lin <[email protected]> wrote:
>
> Hi Kalle,
>
> Patch v4 (https://patchwork.kernel.org/project/linux-wireless/patch/PA4PR04MB963838F12BADC1B9FD377CB7D114A@PA4PR04MB9638.eurprd04.prod.outlook.com/) for host mlme had been submitted for a while.
>
> Current state of this patch is "Deferred". I wonder when can this patch be reviewed and merged.
>
> Is there anything I can do to speed up the acceptance of this patch by upstream?
You still haven't sent this to the correct maintainers (i.e., me) for
one. I also thought there were outstanding unaddressed comments from
Francesco. And given how much Francesco looked, I'd appreciate getting
his Reviewed-by when he's actually happy with it.
(Like I said earlier, I'm not exactly happy that y'all are failing to
maintain this driver, but then insisting the community review and
accept new features. At least if your paying customers will help out
this process, the bargain is less-bad...)
Brian
> From: Brian Norris <[email protected]>
> Sent: Friday, September 15, 2023 9:29 AM
> To: David Lin <[email protected]>
> Cc: [email protected]; [email protected]; Sharvari
> Harisangam <[email protected]>; Pete Hsieh
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Francesco Dolcini <[email protected]>
> Subject: [EXT] Re: [PATCH v4 0/1] Patch History
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Wed, Sep 13, 2023 at 11:42 PM David Lin <[email protected]> wrote:
> >
> > Hi Kalle,
> >
> > Patch v4
> (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.kernel.org%2Fproject%2Flinux-wireless%2Fpatch%2FPA4PR04MB963838
> F12BADC1B9FD377CB7D114A%40PA4PR04MB9638.eurprd04.prod.outlook.co
> m%2F&data=05%7C01%7Cyu-hao.lin%40nxp.com%7C75430d6f96b24d35e2e3
> 08dbb58b1ce5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6383
> 03381314463578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sd
> ata=RqbGAO0rATokTQI76roRAPl3Dr6OQKrhvesU%2FG6cEBU%3D&reserved=0)
> for host mlme had been submitted for a while.
> >
> > Current state of this patch is "Deferred". I wonder when can this
> patch be reviewed and merged.
> >
> > Is there anything I can do to speed up the acceptance of this
> patch by upstream?
>
> You still haven't sent this to the correct maintainers (i.e., me) for one. I also
> thought there were outstanding unaddressed comments from Francesco.
> And given how much Francesco looked, I'd appreciate getting his
> Reviewed-by when he's actually happy with it.
I think I already replied Francesco's feedbacks. For example, patch history and correct maintainers I followed the way described by him to figure out maintainers.
I will add you to the maintainer list.
Following is the mailing list I collected until now. If I still miss someone, please let me know.
<<mwifiex mailing list>>
[email protected]
[email protected];[email protected];[email protected];[email protected];[email protected];[email protected];[email protected];[email protected];[email protected];[email protected];[email protected];[email protected];[email protected];[email protected]
>
> (Like I said earlier, I'm not exactly happy that y'all are failing to maintain this
> driver, but then insisting the community review and accept new features. At
> least if your paying customers will help out this process, the bargain is
> less-bad...)
>
I think we will commit to the code we submitted. In fact, we will have QA to verify patches we submitted and we will continue to submit patches to fix issues reported by our QA or customers to use the code we submitted.
> Brian