On Fri, Sep 15, 2023 at 06:01:04PM +0530, Dhruva Gole wrote:
> Fix the smatch warnings that were recently introduced in the runtime pm
> patch [0]:
> drivers/spi/spi-cadence-quadspi.c:1882 cqspi_probe() warn: missing
> unwind goto?
>
> [0] https://lore.kernel.org/all/[email protected]/
Please use normal fixes tags for things like this and in general
please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on trains or flights, or while
otherwise travelling so this is even more pressing for me than just
being about making things a bit easier to read.
On Sep 15, 2023 at 13:49:23 +0100, Mark Brown wrote:
> On Fri, Sep 15, 2023 at 06:01:04PM +0530, Dhruva Gole wrote:
> > Fix the smatch warnings that were recently introduced in the runtime pm
> > patch [0]:
> > drivers/spi/spi-cadence-quadspi.c:1882 cqspi_probe() warn: missing
> > unwind goto?
> >
> > [0] https://lore.kernel.org/all/[email protected]/
>
> Please use normal fixes tags for things like this and in general
OK, I will resend with fixes tag.
> please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on trains or flights, or while
> otherwise travelling so this is even more pressing for me than just
> being about making things a bit easier to read.
Will keep this in mind!
Also, I think a better fix will do, as I just noticed I am not really
doing a dma_release_channel in this path although I got rid of the
warning.
--
Best regards,
Dhruva Gole <[email protected]>