2023-09-22 01:22:55

by Thomas Gleixner

[permalink] [raw]
Subject: Re: [PATCH v3 06/15] futex: FLAGS_STRICT

On Thu, Sep 21 2023 at 12:45, [email protected] wrote:
> The current semantics for futex_wake() are a bit loose, specifically
> asking for 0 futexes to be woken actually gets you 1.
>
> Adding a !nr check to sys_futex_wake() makes that it would return 0
> for unaligned futex words, because that check comes in the shared
> futex_wake() function. Adding the !nr check there, would affect the
> legacy sys_futex() semantics.
>
> Hence frob a flag :-(
>
> Suggested-by: AndrĂ© Almeida <[email protected]>
> Signed-off-by: Peter Zijlstra (Intel) <[email protected]>

Reviewed-by: Thomas Gleixner <[email protected]>