2023-10-05 14:28:11

by Krzysztof Kozlowski

[permalink] [raw]

Subject: [PATCH] dt-bindings: iio: add missing reset-gpios constrain

---

The Documentation/devicetree/bindings/gpio/gpio-consumer-common.yaml
schema does not enforce number of reset GPIOs, thus each device binding
must do it.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml | 3 ++-
Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml | 3 ++-
Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml | 3 ++-
Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml | 3 ++-
4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
index 2594fa192f93..2a04906531fb 100644
--- a/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
+++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
@@ -32,7 +32,8 @@ properties:

spi-cpol: true

- reset-gpios: true
+ reset-gpios:
+ maxItems: 1

interrupts:
minItems: 1
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
index 4e508bfcc9d8..5121685337b5 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
@@ -78,7 +78,8 @@ properties:
- const: -1000
- const: 22000

- reset-gpios: true
+ reset-gpios:
+ maxItems: 1

adi,dc-dc-ilim-microamp:
enum: [150000, 200000, 250000, 300000, 350000, 400000]
diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
index b9b5beac33b2..5b6cde86b5a5 100644
--- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
+++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
@@ -23,7 +23,8 @@ properties:
maxItems: 1
description: Connected to ADC_RDY pin.

- reset-gpios: true
+ reset-gpios:
+ maxItems: 1

required:
- compatible
diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
index 2958c4ca75b4..167d10bd60af 100644
--- a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
+++ b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
@@ -23,7 +23,8 @@ properties:
maxItems: 1
description: Connected to ADC_RDY pin.

- reset-gpios: true
+ reset-gpios:
+ maxItems: 1

additionalProperties: false

--
2.34.1

2023-10-05 14:48:10

by Conor Dooley

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: iio: add missing reset-gpios constrain

---

On Thu, Oct 05, 2023 at 10:36:50AM +0200, Krzysztof Kozlowski wrote:
> The Documentation/devicetree/bindings/gpio/gpio-consumer-common.yaml
> schema does not enforce number of reset GPIOs, thus each device binding
> must do it.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

> ---
> Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml | 3 ++-
> Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml | 3 ++-
> Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml | 3 ++-
> Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml | 3 ++-
> 4 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> index 2594fa192f93..2a04906531fb 100644
> --- a/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> @@ -32,7 +32,8 @@ properties:
>
> spi-cpol: true
>
> - reset-gpios: true
> + reset-gpios:
> + maxItems: 1
>
> interrupts:
> minItems: 1
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
> index 4e508bfcc9d8..5121685337b5 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
> @@ -78,7 +78,8 @@ properties:
> - const: -1000
> - const: 22000
>
> - reset-gpios: true
> + reset-gpios:
> + maxItems: 1
>
> adi,dc-dc-ilim-microamp:
> enum: [150000, 200000, 250000, 300000, 350000, 400000]
> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> index b9b5beac33b2..5b6cde86b5a5 100644
> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> @@ -23,7 +23,8 @@ properties:
> maxItems: 1
> description: Connected to ADC_RDY pin.
>
> - reset-gpios: true
> + reset-gpios:
> + maxItems: 1
>
> required:
> - compatible
> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> index 2958c4ca75b4..167d10bd60af 100644
> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> @@ -23,7 +23,8 @@ properties:
> maxItems: 1
> description: Connected to ADC_RDY pin.
>
> - reset-gpios: true
> + reset-gpios:
> + maxItems: 1
>
> additionalProperties: false
>
> --
> 2.34.1
>

---

Attachments:

(No filename) (2.82 kB)
signature.asc (235.00 B)
Download all attachments

2023-10-10 16:29:04

by Jonathan Cameron

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: iio: add missing reset-gpios constrain

---

On Thu, 5 Oct 2023 11:41:07 +0100
Conor Dooley <[email protected]> wrote:

> On Thu, Oct 05, 2023 at 10:36:50AM +0200, Krzysztof Kozlowski wrote:
> > The Documentation/devicetree/bindings/gpio/gpio-consumer-common.yaml
> > schema does not enforce number of reset GPIOs, thus each device binding
> > must do it.
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Acked-by: Conor Dooley <[email protected]>

Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan

>
> Thanks,
> Conor.
>
> > ---
> > Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml | 3 ++-
> > Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml | 3 ++-
> > Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml | 3 ++-
> > Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml | 3 ++-
> > 4 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> > index 2594fa192f93..2a04906531fb 100644
> > --- a/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> > +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> > @@ -32,7 +32,8 @@ properties:
> >
> > spi-cpol: true
> >
> > - reset-gpios: true
> > + reset-gpios:
> > + maxItems: 1
> >
> > interrupts:
> > minItems: 1
> > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
> > index 4e508bfcc9d8..5121685337b5 100644
> > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
> > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
> > @@ -78,7 +78,8 @@ properties:
> > - const: -1000
> > - const: 22000
> >
> > - reset-gpios: true
> > + reset-gpios:
> > + maxItems: 1
> >
> > adi,dc-dc-ilim-microamp:
> > enum: [150000, 200000, 250000, 300000, 350000, 400000]
> > diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> > index b9b5beac33b2..5b6cde86b5a5 100644
> > --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> > +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> > @@ -23,7 +23,8 @@ properties:
> > maxItems: 1
> > description: Connected to ADC_RDY pin.
> >
> > - reset-gpios: true
> > + reset-gpios:
> > + maxItems: 1
> >
> > required:
> > - compatible
> > diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> > index 2958c4ca75b4..167d10bd60af 100644
> > --- a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> > +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> > @@ -23,7 +23,8 @@ properties:
> > maxItems: 1
> > description: Connected to ADC_RDY pin.
> >
> > - reset-gpios: true
> > + reset-gpios:
> > + maxItems: 1
> >
> > additionalProperties: false
> >
> > --
> > 2.34.1
> >