2023-10-06 12:03:11

by Bryan O'Donoghue

[permalink] [raw]
Subject: [PATCH 2/5] i2c: qcom-cci: Add sc8280xp compatible

Add sc8280xp compatible with cci_v2_data parameters.

Signed-off-by: Bryan O'Donoghue <[email protected]>
---
drivers/i2c/busses/i2c-qcom-cci.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
index 414882c57d7f..677e4bc6e2c5 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -819,6 +819,7 @@ static const struct of_device_id cci_dt_match[] = {
{ .compatible = "qcom,msm8916-cci", .data = &cci_v1_data},
{ .compatible = "qcom,sdm845-cci", .data = &cci_v2_data},
{ .compatible = "qcom,sm8250-cci", .data = &cci_v2_data},
+ { .compatible = "qcom,sc8280xp-cci", .data = &cci_v2_data},
{ .compatible = "qcom,sm8450-cci", .data = &cci_v2_data},
{}
};
--
2.40.1


2023-10-06 23:22:02

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/5] i2c: qcom-cci: Add sc8280xp compatible

On 6.10.2023 14:01, Bryan O'Donoghue wrote:
> Add sc8280xp compatible with cci_v2_data parameters.
>
> Signed-off-by: Bryan O'Donoghue <[email protected]>
> ---
Drop this patch, it adds nothing useful

Konrad

2023-10-08 21:28:55

by Andi Shyti

[permalink] [raw]
Subject: Re: [PATCH 2/5] i2c: qcom-cci: Add sc8280xp compatible

Hi Konrad,

> > Add sc8280xp compatible with cci_v2_data parameters.
> >
> > Signed-off-by: Bryan O'Donoghue <[email protected]>
> > ---
> Drop this patch, it adds nothing useful

what about the rest of the series?

Could you please be a bit more explicative?

Thanks,
Andi

2023-10-08 22:13:26

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH 2/5] i2c: qcom-cci: Add sc8280xp compatible

On 08/10/2023 22:28, Andi Shyti wrote:
> Hi Konrad,
>
>>> Add sc8280xp compatible with cci_v2_data parameters.
>>>
>>> Signed-off-by: Bryan O'Donoghue <[email protected]>
>>> ---
>> Drop this patch, it adds nothing useful
>
> what about the rest of the series?
>
> Could you please be a bit more explicative?
>
> Thanks,
> Andi

I think he means I can use the sm8250 or sm8450 compat string, which is
true.

---
bod

2023-10-08 22:26:39

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH 2/5] i2c: qcom-cci: Add sc8280xp compatible

On 08/10/2023 23:13, Bryan O'Donoghue wrote:
> On 08/10/2023 22:28, Andi Shyti wrote:
>> Hi Konrad,
>>
>>>> Add sc8280xp compatible with cci_v2_data parameters.
>>>>
>>>> Signed-off-by: Bryan O'Donoghue <[email protected]>
>>>> ---
>>> Drop this patch, it adds nothing useful
>>
>> what about the rest of the series?
>>
>> Could you please be a bit more explicative?
>>
>> Thanks,
>> Andi
>
> I think he means I can use the sm8250 or sm8450 compat string, which is
> true.
>
> ---
> bod

Tested, compat sm8250 works fine.

---
bod

2023-10-09 10:17:12

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/5] i2c: qcom-cci: Add sc8280xp compatible

On 8.10.2023 23:28, Andi Shyti wrote:
> Hi Konrad,
>
>>> Add sc8280xp compatible with cci_v2_data parameters.
>>>
>>> Signed-off-by: Bryan O'Donoghue <[email protected]>
>>> ---
>> Drop this patch, it adds nothing useful
>
> what about the rest of the series?
>
> Could you please be a bit more explicative?
This patch introduces a new compatible in the driver that does
exactly nothing, as the bindings require the use of
"qcom,sc8280xp-cci" with a fallback of "qcom,msm8996-cci". The
latter one already has a match table entry.

Konrad