2023-10-07 01:21:09

by Yang Li

Subject: [PATCH -next] firmware: arm_scmi: Remove unneeded semicolon

./drivers/firmware/arm_scmi/clock.c:236:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6717
Signed-off-by: Yang Li <[email protected]>
---
drivers/firmware/arm_scmi/clock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c
index ddaef34cd88b..432812205775 100644
--- a/drivers/firmware/arm_scmi/clock.c
+++ b/drivers/firmware/arm_scmi/clock.c
@@ -233,7 +233,7 @@ static int iter_clk_possible_parents_update_state(struct scmi_iterator_state *st
}

st->max_resources = st->num_returned + st->num_remaining;
- };
+ }

return 0;
}
--
2.20.1.7.g153144c

2023-10-08 08:46:21

by Sudeep Holla

Subject: Re: [PATCH -next] firmware: arm_scmi: Remove unneeded semicolon

On Sat, Oct 07, 2023 at 09:20:58AM +0800, Yang Li wrote:
> ./drivers/firmware/arm_scmi/clock.c:236:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6717
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/firmware/arm_scmi/clock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c
> index ddaef34cd88b..432812205775 100644
> --- a/drivers/firmware/arm_scmi/clock.c
> +++ b/drivers/firmware/arm_scmi/clock.c
> @@ -233,7 +233,7 @@ static int iter_clk_possible_parents_update_state(struct scmi_iterator_state *st
> }
>
> st->max_resources = st->num_returned + st->num_remaining;
> - };
> + }
>

The patch introducing this is being waited for an Ack and not finalised yet.
I will fold in the changes. Thanks for pointing it out, much appreciated!

--
Regards,
Sudeep