2023-10-12 15:26:48

by Paolo Bonzini

Subject: [PATCH] KVM: MIPS: fix -Wunused-but-set-variable warning

The variable is completely unused, remove it.

Signed-off-by: Paolo Bonzini <[email protected]>
---
arch/mips/kvm/mmu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/mips/kvm/mmu.c b/arch/mips/kvm/mmu.c
index 7b2ac1319d70..467ee6b95ae1 100644
--- a/arch/mips/kvm/mmu.c
+++ b/arch/mips/kvm/mmu.c
@@ -592,7 +592,7 @@ static int kvm_mips_map_page(struct kvm_vcpu *vcpu, unsigned long gpa,
gfn_t gfn = gpa >> PAGE_SHIFT;
int srcu_idx, err;
kvm_pfn_t pfn;
- pte_t *ptep, entry, old_pte;
+ pte_t *ptep, entry;
bool writeable;
unsigned long prot_bits;
unsigned long mmu_seq;
@@ -664,7 +664,6 @@ static int kvm_mips_map_page(struct kvm_vcpu *vcpu, unsigned long gpa,
entry = pfn_pte(pfn, __pgprot(prot_bits));

/* Write the PTE */
- old_pte = *ptep;
set_pte(ptep, entry);

err = 0;
--
2.39.0

2023-10-13 16:13:39

by Sean Christopherson

Subject: Re: [PATCH] KVM: MIPS: fix -Wunused-but-set-variable warning

On Thu, Oct 12, 2023, Paolo Bonzini wrote:
> The variable is completely unused, remove it.
>
> Signed-off-by: Paolo Bonzini <[email protected]>
> ---
> arch/mips/kvm/mmu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/kvm/mmu.c b/arch/mips/kvm/mmu.c
> index 7b2ac1319d70..467ee6b95ae1 100644
> --- a/arch/mips/kvm/mmu.c
> +++ b/arch/mips/kvm/mmu.c
> @@ -592,7 +592,7 @@ static int kvm_mips_map_page(struct kvm_vcpu *vcpu, unsigned long gpa,
> gfn_t gfn = gpa >> PAGE_SHIFT;
> int srcu_idx, err;
> kvm_pfn_t pfn;
> - pte_t *ptep, entry, old_pte;
> + pte_t *ptep, entry;
> bool writeable;
> unsigned long prot_bits;
> unsigned long mmu_seq;
> @@ -664,7 +664,6 @@ static int kvm_mips_map_page(struct kvm_vcpu *vcpu, unsigned long gpa,
> entry = pfn_pte(pfn, __pgprot(prot_bits));
>
> /* Write the PTE */
> - old_pte = *ptep;
> set_pte(ptep, entry);

Heh, 7 year old bug gets two fixes within a few days :-)

https://lore.kernel.org/all/[email protected]