2007-11-20 00:16:31

by Kevin Winchester

[permalink] [raw]
Subject: [PATCH mmotm] Fix missing closing parenthesis in binfmt_elf.c


An obviously missing closing parenthesis.

Signed-off-by: Kevin Winchester <[email protected]>

---

This is more for practice sending patches than anything else, to make
sure they are not damaged in any way.

But it does bring up a good question. Are patches expected/wanted for
the mmotm kernels?

Index: linux-mm/fs/binfmt_elf.c
===================================================================
--- linux-mm.orig/fs/binfmt_elf.c 2007-11-19 20:01:00.000000000 -0400
+++ linux-mm/fs/binfmt_elf.c 2007-11-19 20:02:34.000000000 -0400
@@ -1031,7 +1031,7 @@
}

if (elf_interpreter) {
- if (IS_AOUT_INTERP(interpreter_type) {
+ if (IS_AOUT_INTERP(interpreter_type)) {
elf_entry = load_aout_interp(&loc->interp_ex,
interpreter);
} else {


2007-11-20 00:40:25

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH mmotm] Fix missing closing parenthesis in binfmt_elf.c

On Mon, 19 Nov 2007 20:16:20 -0400
Kevin Winchester <[email protected]> wrote:

>
> An obviously missing closing parenthesis.
>

I'm going through complete misery with that file.

>
> ---
>
> This is more for practice sending patches than anything else, to make
> sure they are not damaged in any way.
>
> But it does bring up a good question. Are patches expected/wanted for
> the mmotm kernels?

Sure, thanks.

> Index: linux-mm/fs/binfmt_elf.c
> ===================================================================
> --- linux-mm.orig/fs/binfmt_elf.c 2007-11-19 20:01:00.000000000 -0400
> +++ linux-mm/fs/binfmt_elf.c 2007-11-19 20:02:34.000000000 -0400
> @@ -1031,7 +1031,7 @@
> }
>
> if (elf_interpreter) {
> - if (IS_AOUT_INTERP(interpreter_type) {
> + if (IS_AOUT_INTERP(interpreter_type)) {
> elf_entry = load_aout_interp(&loc->interp_ex,
> interpreter);
> } else {