2023-10-21 02:02:26

by Gao Xiang

[permalink] [raw]
Subject: [PATCH] erofs: don't warn MicroLZMA format anymore

The LZMA algorithm support has been landed for more than one year since
Linux 5.16. Besides, the new XZ Utils 5.4 has been available in most
Linux distributions.

Signed-off-by: Gao Xiang <[email protected]>
---
fs/erofs/Kconfig | 7 ++-----
fs/erofs/decompressor_lzma.c | 2 --
2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
index f6dc961e6c2b..e540648dedc2 100644
--- a/fs/erofs/Kconfig
+++ b/fs/erofs/Kconfig
@@ -91,13 +91,10 @@ config EROFS_FS_ZIP_LZMA
select XZ_DEC_MICROLZMA
help
Saying Y here includes support for reading EROFS file systems
- containing LZMA compressed data, specifically called microLZMA. it
- gives better compression ratios than the LZ4 algorithm, at the
+ containing LZMA compressed data, specifically called microLZMA. It
+ gives better compression ratios than the default LZ4 format, at the
expense of more CPU overhead.

- LZMA support is an experimental feature for now and so most file
- systems will be readable without selecting this option.
-
If unsure, say N.

config EROFS_FS_ZIP_DEFLATE
diff --git a/fs/erofs/decompressor_lzma.c b/fs/erofs/decompressor_lzma.c
index ba4ec73f4aae..852dd8eac5df 100644
--- a/fs/erofs/decompressor_lzma.c
+++ b/fs/erofs/decompressor_lzma.c
@@ -96,8 +96,6 @@ int z_erofs_load_lzma_config(struct super_block *sb,
return -EINVAL;
}

- erofs_info(sb, "EXPERIMENTAL MicroLZMA in use. Use at your own risk!");
-
/* in case 2 z_erofs_load_lzma_config() race to avoid deadlock */
mutex_lock(&lzma_resize_mutex);

--
2.39.3


2023-10-30 14:50:44

by Chao Yu

[permalink] [raw]
Subject: Re: [PATCH] erofs: don't warn MicroLZMA format anymore

On 2023/10/21 10:01, Gao Xiang wrote:
> The LZMA algorithm support has been landed for more than one year since
> Linux 5.16. Besides, the new XZ Utils 5.4 has been available in most
> Linux distributions.
>
> Signed-off-by: Gao Xiang <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,