2023-10-23 05:48:03

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warnings after merge of the iommufd tree

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced these warnings:

include/uapi/linux/iommufd.h:433: warning: expecting prototype for enum iommufd_hw_info_capabilities. Prototype was for enum iommufd_hw_capabilities instead
include/uapi/linux/iommufd.h:497: warning: Function parameter or member '__reserved' not described in 'iommu_hwpt_set_dirty_tracking'
include/uapi/linux/iommufd.h:512: warning: expecting prototype for enum iommufd_get_dirty_bitmap_flags. Prototype was for enum iommufd_hwpt_get_dirty_bitmap_flags instead
include/uapi/linux/iommufd.h:542: warning: Function parameter or member '__reserved' not described in 'iommu_hwpt_get_dirty_bitmap'

Introduced by commits

f87900f25050 ("iommufd: Add a flag to skip clearing of IOPTE dirty")
d2b3a545cdcc ("iommufd: Add capabilities to IOMMU_GET_HW_INFO")
1337d793ea25 ("iommufd: Add IOMMU_HWPT_GET_DIRTY_BITMAP")
ccccda6d18bd ("iommufd: Add IOMMU_HWPT_SET_DIRTY_TRACKING")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2023-10-23 10:44:01

by Joao Martins

[permalink] [raw]
Subject: Re: linux-next: build warnings after merge of the iommufd tree

On 23/10/2023 06:47, Stephen Rothwell wrote:
> Hi all,
>
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> include/uapi/linux/iommufd.h:433: warning: expecting prototype for enum iommufd_hw_info_capabilities. Prototype was for enum iommufd_hw_capabilities instead
> include/uapi/linux/iommufd.h:497: warning: Function parameter or member '__reserved' not described in 'iommu_hwpt_set_dirty_tracking'
> include/uapi/linux/iommufd.h:512: warning: expecting prototype for enum iommufd_get_dirty_bitmap_flags. Prototype was for enum iommufd_hwpt_get_dirty_bitmap_flags instead
> include/uapi/linux/iommufd.h:542: warning: Function parameter or member '__reserved' not described in 'iommu_hwpt_get_dirty_bitmap'
>
Thanks

I've fixed these warnings in the offending patches below; for the next version.

> Introduced by commits
>
> f87900f25050 ("iommufd: Add a flag to skip clearing of IOPTE dirty")
> d2b3a545cdcc ("iommufd: Add capabilities to IOMMU_GET_HW_INFO")
> 1337d793ea25 ("iommufd: Add IOMMU_HWPT_GET_DIRTY_BITMAP")
> ccccda6d18bd ("iommufd: Add IOMMU_HWPT_SET_DIRTY_TRACKING")
>