2023-10-23 11:30:03

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.4 000/123] 5.4.259-rc1 review

This is the start of the stable review cycle for the 5.4.259 release.
There are 123 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.259-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.4.259-rc1

Zhang Changzhong <[email protected]>
xfrm6: fix inet6_dev refcount underflow problem

Kees Cook <[email protected]>
Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name

Edward AD <[email protected]>
Bluetooth: hci_sock: fix slab oob read in create_monitor_event

Tony Lindgren <[email protected]>
phy: mapphone-mdm6600: Fix pinctrl_pm handling for sleep pins

Tony Lindgren <[email protected]>
phy: mapphone-mdm6600: Fix runtime PM for remove

Tony Lindgren <[email protected]>
phy: mapphone-mdm6600: Fix runtime disable on probe

Haibo Chen <[email protected]>
gpio: vf610: mask the gpio irq in system suspend and support wakeup

Alexander Stein <[email protected]>
gpio: vf610: make irq_chip immutable

Dan Carpenter <[email protected]>
ASoC: pxa: fix a memory leak in probe()

Haibo Chen <[email protected]>
gpio: vf610: set value before the direction to avoid a glitch

Niklas Schnelle <[email protected]>
s390/pci: fix iommu bitmap allocation

Peter Zijlstra <[email protected]>
perf: Disallow mis-matched inherited group reads

Puliang Lu <[email protected]>
USB: serial: option: add Fibocom to DELL custom modem FM101R-GL

Benoît Monin <[email protected]>
USB: serial: option: add entry for Sierra EM9191 with new firmware

Fabio Porcedda <[email protected]>
USB: serial: option: add Telit LE910C4-WWX 0x1035 composition

Sunil V L <[email protected]>
ACPI: irq: Fix incorrect return value in acpi_register_gsi()

Andy Shevchenko <[email protected]>
Revert "pinctrl: avoid unsafe code pattern in find_pinctrl()"

Avri Altman <[email protected]>
mmc: core: Capture correct oemid-bits for eMMC cards

Haibo Chen <[email protected]>
mmc: core: sdio: hold retuning if sdio in 1-bit mode

Geert Uytterhoeven <[email protected]>
mtd: physmap-core: Restore map_rom fallback

Martin Kurbanov <[email protected]>
mtd: spinand: micron: correct bitmask for ecc status

Bibek Kumar Patro <[email protected]>
mtd: rawnand: qcom: Unmap the right resource upon probe failure

Luiz Augusto von Dentz <[email protected]>
Bluetooth: hci_event: Fix using memcmp when comparing keys

Rahul Rameshbabu <[email protected]>
HID: multitouch: Add required quirk for Synaptics 0xcd7e device

Josef Bacik <[email protected]>
btrfs: fix some -Wmaybe-uninitialized warnings in ioctl.c

Kai Uwe Broulik <[email protected]>
drm: panel-orientation-quirks: Add quirk for One Mix 2S

Kees Cook <[email protected]>
sky2: Make sure there is at least one frag_addr available

Michał Mirosław <[email protected]>
regulator/core: Revert "fix kobject release warning and memory leak in regulator_register()"

Benjamin Berg <[email protected]>
wifi: cfg80211: avoid leaking stack data into trace

Wen Gong <[email protected]>
wifi: mac80211: allow transmitting EAPOL frames with tainted key

Luiz Augusto von Dentz <[email protected]>
Bluetooth: hci_core: Fix build warnings

Ying Hsu <[email protected]>
Bluetooth: Avoid redundant authentication

Ma Ke <[email protected]>
HID: holtek: fix slab-out-of-bounds Write in holtek_kbd_input_event

Clément Léger <[email protected]>
tracing: relax trace_event_eval_update() execution with cond_resched()

Damien Le Moal <[email protected]>
ata: libata-eh: Fix compilation warning in ata_eh_link_report()

Chengfeng Ye <[email protected]>
gpio: timberdale: Fix potential deadlock on &tgpio->lock

Jeff Layton <[email protected]>
overlayfs: set ctime when setting mtime and atime

Heiner Kallweit <[email protected]>
i2c: mux: Avoid potential false error message in i2c_mux_add_adapter

Josef Bacik <[email protected]>
btrfs: initialize start_slot in btrfs_log_prealloc_extents

Filipe Manana <[email protected]>
btrfs: return -EUCLEAN for delayed tree ref with a ref count not equals to 1

Tony Lindgren <[email protected]>
ARM: dts: ti: omap: Fix noisy serial with overrun-throttle-ms for mapphone

Hans de Goede <[email protected]>
ACPI: resource: Skip IRQ override on ASUS ExpertBook B1402CBA

Paul Menzel <[email protected]>
ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CBA

Tamim Khan <[email protected]>
ACPI: resource: Skip IRQ override on Asus Expertbook B2402CBA

Hans de Goede <[email protected]>
ACPI: resource: Add Asus ExpertBook B2502 to Asus quirks

Tamim Khan <[email protected]>
ACPI: resource: Skip IRQ override on Asus Vivobook S5602ZA

Kellen Renshaw <[email protected]>
ACPI: resource: Add ASUS model S5402ZA to quirks

Tamim Khan <[email protected]>
ACPI: resource: Skip IRQ override on Asus Vivobook K3402ZA/K3502ZA

Hui Wang <[email protected]>
ACPI: resources: Add DMI-based legacy IRQ override quirk

John Garry <[email protected]>
ACPI: Drop acpi_dev_irqresource_disabled()

John Garry <[email protected]>
resource: Add irqresource_disabled()

Gavrilov Ilia <[email protected]>
net: pktgen: Fix interface flags printing

Pablo Neira Ayuso <[email protected]>
netfilter: nft_set_rbtree: .deactivate fails if element has expired

Geert Uytterhoeven <[email protected]>
neighbor: tracing: Move pin6 inside CONFIG_IPV6=y section

Pedro Tammela <[email protected]>
net/sched: sch_hfsc: upgrade 'rt' to 'sc' when it becomes a inner curve

Michal Schmidt <[email protected]>
i40e: prevent crash on probe if hw registers have invalid values

Dan Carpenter <[email protected]>
net: usb: smsc95xx: Fix an error code in smsc95xx_reset()

Eric Dumazet <[email protected]>
ipv4: fib: annotate races around nh->nh_saddr_genid and nh->nh_saddr

Eric Dumazet <[email protected]>
tun: prevent negative ifindex

Eric Dumazet <[email protected]>
tcp: tsq: relax tcp_small_queue_check() when rtx queue contains a single skb

Neal Cardwell <[email protected]>
tcp: fix excessive TLP and RACK timeouts from HZ rounding

Josua Mayer <[email protected]>
net: rfkill: gpio: prevent value glitch during probe

Ma Ke <[email protected]>
net: ipv6: fix return value check in esp_remove_trailer

Ma Ke <[email protected]>
net: ipv4: fix return value check in esp_remove_trailer

Eric Dumazet <[email protected]>
xfrm: interface: use DEV_STATS_INC()

Eric Dumazet <[email protected]>
xfrm: fix a data-race in xfrm_gen_index()

Manish Chopra <[email protected]>
qed: fix LL2 RX buffer allocation

Florian Westphal <[email protected]>
netfilter: nft_payload: fix wrong mac header matching

Jim Mattson <[email protected]>
KVM: x86: Mask LVTPC when handling a PMI

Johan Hovold <[email protected]>
regmap: fix NULL deref on lookup

Krzysztof Kozlowski <[email protected]>
nfc: nci: fix possible NULL pointer dereference in send_acknowledge()

Jesse Brandeburg <[email protected]>
ice: fix over-shifted variable

Arnd Bergmann <[email protected]>
Bluetooth: avoid memcmp() out of bounds warning

Luiz Augusto von Dentz <[email protected]>
Bluetooth: hci_event: Fix coding style

Arkadiusz Bokowy <[email protected]>
Bluetooth: vhci: Fix race when opening vhci device

Ziyang Xuan <[email protected]>
Bluetooth: Fix a refcnt underflow problem for hci_conn

Lee, Chun-Yi <[email protected]>
Bluetooth: Reject connection with the device which has same BD_ADDR

Lee, Chun-Yi <[email protected]>
Bluetooth: hci_event: Ignore NULL link key

Ricardo Cañuelo <[email protected]>
usb: hub: Guard against accesses to uninitialized BOS descriptors

Bagas Sanjaya <[email protected]>
Documentation: sysctl: align cells in second content column

Nicolas Dichtel <[email protected]>
dev_forward_skb: do not scrub skb mark within the same name space

Yoshihiro Shimoda <[email protected]>
ravb: Fix use-after-free issue in ravb_tx_timeout_work()

Christophe Leroy <[email protected]>
powerpc/64e: Fix wrong test in __ptep_test_and_clear_young()

Christophe Leroy <[email protected]>
powerpc/8xx: Fix pte_access_permitted() for PAGE_NONE

Duoming Zhou <[email protected]>
dmaengine: mediatek: Fix deadlock caused by synchronize_irq()

Borislav Petkov (AMD) <[email protected]>
x86/cpu: Fix AMD erratum #1485 on Zen4-based CPUs

Krishna Kurapati <[email protected]>
usb: gadget: ncm: Handle decoding of multiple NTB's in unwrap call

Piyush Mehta <[email protected]>
usb: gadget: udc-xilinx: replace memcpy with memcpy_toio

Dmitry Torokhov <[email protected]>
pinctrl: avoid unsafe code pattern in find_pinctrl()

Michal Koutný <[email protected]>
cgroup: Remove duplicates in cgroup v1 tasks file

Matthias Berndt <[email protected]>
Input: xpad - add PXN V900 support

Jeffery Miller <[email protected]>
Input: psmouse - fix fast_reconnect function for PS/2 mode

Javier Carrasco <[email protected]>
Input: powermate - fix use-after-free in powermate_config_complete

Xiubo Li <[email protected]>
ceph: fix incorrect revoked caps assert in ceph_fill_file_size()

Jordan Rife <[email protected]>
libceph: use kernel_connect()

Jorge Sanjuan Garcia <[email protected]>
mcb: remove is_added flag from mcb_device struct

Alexander Zangerl <[email protected]>
iio: pressure: ms5611: ms5611_prom_is_valid false negative bug

Lakshmi Yadlapati <[email protected]>
iio: pressure: dps310: Adjust Timeout Settings

Phil Elwell <[email protected]>
iio: pressure: bmp280: Fix NULL pointer exception

Xingxing Luo <[email protected]>
usb: musb: Modify the "HWVers" register address

Xingxing Luo <[email protected]>
usb: musb: Get the musb_qh poniter after musb_giveback

Thinh Nguyen <[email protected]>
usb: dwc3: Soft reset phy on probe for host

Javier Carrasco <[email protected]>
net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read

Wesley Cheng <[email protected]>
usb: xhci: xhci-ring: Use sysdev for mapping bounce buffer

Amelie Delaunay <[email protected]>
dmaengine: stm32-mdma: abort resume if no ongoing transfer

Waiman Long <[email protected]>
workqueue: Override implicit ordered attribute in workqueue_apply_unbound_cpumask()

Jeremy Cline <[email protected]>
nfc: nci: assert requested protocol is valid

Eric Dumazet <[email protected]>
net: nfc: fix races in nfc_llcp_sock_get() and nfc_llcp_sock_get_sn()

Dan Carpenter <[email protected]>
ixgbe: fix crash with empty VF macvlan list

Konstantin Meskhidze <[email protected]>
drm/vmwgfx: fix typo of sizeof argument

Roger Pau Monne <[email protected]>
xen-netback: use default TX queue size for vifs

Dan Carpenter <[email protected]>
mlxsw: fix mlxsw_sp2_nve_vxlan_learning_set() return type

Dinghao Liu <[email protected]>
ieee802154: ca8210: Fix a potential UAF in ca8210_probe

Yoshihiro Shimoda <[email protected]>
ravb: Fix up dma_free_coherent() call in ravb_remove()

Abhinav Kumar <[email protected]>
drm/msm/dsi: skip the wait for video mode done if not applicable

Martin Fuzzey <[email protected]>
drm: etvnaviv: fix bad backport leading to warning

Jordan Rife <[email protected]>
net: prevent address rewrite in kernel_bind()

Jan Kara <[email protected]>
quota: Fix slow quotaoff

Hans de Goede <[email protected]>
HID: logitech-hidpp: Fix kernel crash on receiver USB disconnect

Uwe Kleine-König <[email protected]>
pwm: hibvt: Explicitly set .polarity in .get_state()

Greg Kroah-Hartman <[email protected]>
lib/test_meminit: fix off-by-one error in test_pages()

Uwe Kleine-König <[email protected]>
platform/x86: hp-wmi:: Mark driver struct with __refdata to prevent section mismatch warning

Artem Chernyshev <[email protected]>
RDMA/cxgb4: Check skb value for failure to allocate


-------------

Diffstat:

Documentation/admin-guide/sysctl/net.rst | 18 +--
Makefile | 4 +-
arch/arm/boot/dts/omap4-droid4-xt894.dts | 1 +
arch/powerpc/include/asm/nohash/32/pte-8xx.h | 7 ++
arch/powerpc/include/asm/nohash/64/pgtable.h | 2 +-
arch/powerpc/include/asm/nohash/pgtable.h | 2 +
arch/s390/pci/pci_dma.c | 15 ++-
arch/x86/include/asm/msr-index.h | 4 +
arch/x86/kernel/cpu/amd.c | 8 ++
arch/x86/kvm/lapic.c | 8 +-
drivers/acpi/irq.c | 7 +-
drivers/acpi/resource.c | 121 +++++++++++++++++++--
drivers/ata/libata-eh.c | 2 +-
drivers/base/regmap/regmap.c | 2 +-
drivers/bluetooth/hci_vhci.c | 3 +
drivers/dma/mediatek/mtk-uart-apdma.c | 3 +-
drivers/dma/stm32-mdma.c | 4 +
drivers/gpio/gpio-timberdale.c | 5 +-
drivers/gpio/gpio-vf610.c | 46 ++++----
drivers/gpu/drm/drm_panel_orientation_quirks.c | 16 +++
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
drivers/gpu/drm/msm/dsi/dsi_host.c | 12 ++
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
drivers/hid/hid-holtek-kbd.c | 4 +
drivers/hid/hid-logitech-hidpp.c | 3 +-
drivers/hid/hid-multitouch.c | 4 +
drivers/i2c/i2c-mux.c | 2 +-
drivers/iio/pressure/bmp280-core.c | 2 +-
drivers/iio/pressure/dps310.c | 8 +-
drivers/iio/pressure/ms5611_core.c | 2 +-
drivers/infiniband/hw/cxgb4/cm.c | 3 +
drivers/input/joystick/xpad.c | 2 +
drivers/input/misc/powermate.c | 1 +
drivers/input/mouse/elantech.c | 1 +
drivers/input/mouse/synaptics.c | 1 +
drivers/mcb/mcb-core.c | 10 +-
drivers/mcb/mcb-parse.c | 2 -
drivers/mmc/core/mmc.c | 2 +-
drivers/mmc/core/sdio.c | 8 +-
drivers/mtd/maps/physmap-core.c | 11 ++
drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
drivers/mtd/nand/spi/micron.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_common.c | 4 +-
drivers/net/ethernet/intel/ice/ice_lib.c | 3 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 5 +-
drivers/net/ethernet/marvell/sky2.h | 2 +-
.../ethernet/mellanox/mlxsw/spectrum_nve_vxlan.c | 4 +-
drivers/net/ethernet/qlogic/qed/qed_ll2.c | 7 +-
drivers/net/ethernet/renesas/ravb_main.c | 6 +-
drivers/net/ieee802154/ca8210.c | 17 +--
drivers/net/tun.c | 7 +-
drivers/net/usb/dm9601.c | 7 +-
drivers/net/usb/smsc95xx.c | 2 +-
drivers/net/xen-netback/interface.c | 3 -
drivers/phy/motorola/phy-mapphone-mdm6600.c | 38 +++----
drivers/platform/x86/hp-wmi.c | 8 +-
drivers/pwm/pwm-hibvt.c | 1 +
drivers/regulator/core.c | 6 +-
drivers/usb/core/hub.c | 28 ++++-
drivers/usb/core/hub.h | 2 +-
drivers/usb/dwc3/core.c | 39 ++++++-
drivers/usb/gadget/function/f_ncm.c | 26 +++--
drivers/usb/gadget/udc/udc-xilinx.c | 20 ++--
drivers/usb/host/xhci-ring.c | 4 +-
drivers/usb/musb/musb_debugfs.c | 2 +-
drivers/usb/musb/musb_host.c | 9 +-
drivers/usb/serial/option.c | 7 ++
fs/btrfs/extent-tree.c | 6 +-
fs/btrfs/ioctl.c | 4 +-
fs/btrfs/tree-log.c | 2 +-
fs/ceph/inode.c | 4 +-
fs/overlayfs/copy_up.c | 2 +-
fs/quota/dquot.c | 66 ++++++-----
include/linux/ioport.h | 7 ++
include/linux/mcb.h | 1 -
include/linux/netdevice.h | 2 +-
include/linux/perf_event.h | 1 +
include/linux/quota.h | 4 +-
include/linux/quotaops.h | 2 +-
include/net/bluetooth/hci_core.h | 2 +-
include/net/bluetooth/hci_mon.h | 2 +-
include/net/netns/xfrm.h | 1 +
include/net/tcp.h | 3 +
include/trace/events/neigh.h | 4 +-
kernel/cgroup/cgroup-v1.c | 5 +-
kernel/events/core.c | 39 ++++++-
kernel/trace/trace_events.c | 1 +
kernel/workqueue.c | 8 +-
lib/test_meminit.c | 2 +-
net/bluetooth/hci_conn.c | 72 +++++++-----
net/bluetooth/hci_core.c | 8 +-
net/bluetooth/hci_event.c | 33 +++++-
net/bluetooth/hci_sock.c | 3 +-
net/ceph/messenger.c | 4 +-
net/core/pktgen.c | 14 +--
net/ipv4/esp4.c | 4 +-
net/ipv4/fib_semantics.c | 14 ++-
net/ipv4/tcp_output.c | 25 ++++-
net/ipv4/tcp_recovery.c | 2 +-
net/ipv6/esp6.c | 4 +-
net/ipv6/xfrm6_policy.c | 4 +-
net/mac80211/tx.c | 3 +-
net/netfilter/ipvs/ip_vs_sync.c | 4 +-
net/netfilter/nft_payload.c | 2 +-
net/netfilter/nft_set_rbtree.c | 2 +
net/nfc/llcp_core.c | 30 ++---
net/nfc/nci/core.c | 5 +
net/nfc/nci/spi.c | 2 +
net/rds/tcp_connect.c | 2 +-
net/rds/tcp_listen.c | 2 +-
net/rfkill/rfkill-gpio.c | 4 +-
net/sched/sch_hfsc.c | 18 ++-
net/socket.c | 6 +-
net/wireless/nl80211.c | 2 +-
net/xfrm/xfrm_interface_core.c | 22 ++--
net/xfrm/xfrm_policy.c | 6 +-
sound/soc/pxa/pxa-ssp.c | 2 +-
117 files changed, 757 insertions(+), 331 deletions(-)



2023-10-23 14:36:51

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/123] 5.4.259-rc1 review

On 10/23/23 03:55, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.259 release.
> There are 123 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000.
> Anything received after that time might be too late.
>

drivers/gpio/gpio-vf610.c:249:18: error: 'IRQCHIP_IMMUTABLE' undeclared here (not in a function); did you mean 'IS_IMMUTABLE'?
249 | .flags = IRQCHIP_IMMUTABLE | IRQCHIP_MASK_ON_SUSPEND
| ^~~~~~~~~~~~~~~~~
| IS_IMMUTABLE
drivers/gpio/gpio-vf610.c:250:27: error: 'IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND' undeclared here (not in a function); did you mean 'IRQCHIP_MASK_ON_SUSPEND'?
250 | | IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| IRQCHIP_MASK_ON_SUSPEND
drivers/gpio/gpio-vf610.c:251:9: error: 'GPIOCHIP_IRQ_RESOURCE_HELPERS' undeclared here (not in a function)
251 | GPIOCHIP_IRQ_RESOURCE_HELPERS,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpio/gpio-vf610.c:251:9: warning: excess elements in struct initializer
drivers/gpio/gpio-vf610.c:251:9: note: (near initialization for 'vf610_irqchip')
drivers/gpio/gpio-vf610.c: In function 'vf610_gpio_probe':
drivers/gpio/gpio-vf610.c:340:9: error: implicit declaration of function 'gpio_irq_chip_set_chip'

Also affects v5.10.y and v5.15.y.

Guenter

2023-10-23 15:53:27

by Daniel Díaz

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/123] 5.4.259-rc1 review

Hello!

On 23/10/23 4:55 a. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.259 release.
> There are 123 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.259-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Same problems on Arm 32-bits as with 5.10 and 5.15:

-----8<-----
/builds/linux/drivers/gpio/gpio-vf610.c:249:11: error: use of undeclared identifier 'IRQCHIP_IMMUTABLE'
249 | .flags = IRQCHIP_IMMUTABLE | IRQCHIP_MASK_ON_SUSPEND
| ^
/builds/linux/drivers/gpio/gpio-vf610.c:250:6: error: use of undeclared identifier 'IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND'
250 | | IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND,
| ^
/builds/linux/drivers/gpio/gpio-vf610.c:251:2: error: use of undeclared identifier 'GPIOCHIP_IRQ_RESOURCE_HELPERS'
251 | GPIOCHIP_IRQ_RESOURCE_HELPERS,
| ^
/builds/linux/drivers/gpio/gpio-vf610.c:340:2: error: implicit declaration of function 'gpio_irq_chip_set_chip' [-Werror,-Wimplicit-function-declaration]
340 | gpio_irq_chip_set_chip(girq, &vf610_irqchip);
| ^
4 errors generated.
make[3]: *** [/builds/linux/scripts/Makefile.build:262: drivers/gpio/gpio-vf610.o] Error 1
make[3]: Target '__build' not remade because of errors.
make[2]: *** [/builds/linux/scripts/Makefile.build:497: drivers/gpio] Error 2
/builds/linux/drivers/gpu/drm/drm_lock.c:363:6: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
363 | */ mutex_lock(&dev->struct_mutex);
| ^
/builds/linux/drivers/gpu/drm/drm_lock.c:357:2: note: previous statement is here
357 | if (!drm_core_check_feature(dev, DRIVER_LEGACY))
| ^
1 warning generated.
----->8-----

Reported-by: Linux Kernel Functional Testing <[email protected]>

Affected builds:
* clang-17-defconfig arm
* clang-17-imx_v6_v7_defconfig arm
* clang-17-lkftconfig arm
* clang-17-lkftconfig-no-kselftest-frag arm
* clang-nightly-defconfig arm
* clang-nightly-imx_v6_v7_defconfig arm
* clang-nightly-lkftconfig arm
* clang-nightly-lkftconfig-kselftest arm
* gcc-8-defconfig arm
* gcc-8-imx_v6_v7_defconfig arm
* gcc-10-lkftconfig arm
* gcc-10-lkftconfig-debug arm
* gcc-10-lkftconfig-debug-kmemleak arm
* gcc-10-lkftconfig-kselftest-kernel arm
* gcc-10-lkftconfig-libgpiod arm
* gcc-10-lkftconfig-perf-kernel arm
* gcc-10-lkftconfig-rcutorture arm
* gcc-12-defconfig arm
* gcc-12-imx_v6_v7_defconfig arm
* gcc-12-lkftconfig arm
* gcc-12-lkftconfig-debug arm
* gcc-12-lkftconfig-debug-kmemleak arm
* gcc-12-lkftconfig-kasan arm
* gcc-12-lkftconfig-kselftest arm
* gcc-12-lkftconfig-kunit arm
* gcc-12-lkftconfig-libgpiod arm
* gcc-12-lkftconfig-no-kselftest-frag arm
* gcc-12-lkftconfig-perf arm
* gcc-12-lkftconfig-rcutorture arm

Greetings!

Daniel Díaz
[email protected]

2023-10-23 18:38:46

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/123] 5.4.259-rc1 review

On 10/23/23 03:55, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.259 release.
> There are 123 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.259-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:

Tested-by: Florian Fainelli <[email protected]>
--
Florian

2023-10-24 08:26:27

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/123] 5.4.259-rc1 review

On Mon, Oct 23, 2023 at 07:36:25AM -0700, Guenter Roeck wrote:
> On 10/23/23 03:55, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.259 release.
> > There are 123 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000.
> > Anything received after that time might be too late.
> >
>
> drivers/gpio/gpio-vf610.c:249:18: error: 'IRQCHIP_IMMUTABLE' undeclared here (not in a function); did you mean 'IS_IMMUTABLE'?
> 249 | .flags = IRQCHIP_IMMUTABLE | IRQCHIP_MASK_ON_SUSPEND
> | ^~~~~~~~~~~~~~~~~
> | IS_IMMUTABLE
> drivers/gpio/gpio-vf610.c:250:27: error: 'IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND' undeclared here (not in a function); did you mean 'IRQCHIP_MASK_ON_SUSPEND'?
> 250 | | IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | IRQCHIP_MASK_ON_SUSPEND
> drivers/gpio/gpio-vf610.c:251:9: error: 'GPIOCHIP_IRQ_RESOURCE_HELPERS' undeclared here (not in a function)
> 251 | GPIOCHIP_IRQ_RESOURCE_HELPERS,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpio/gpio-vf610.c:251:9: warning: excess elements in struct initializer
> drivers/gpio/gpio-vf610.c:251:9: note: (near initialization for 'vf610_irqchip')
> drivers/gpio/gpio-vf610.c: In function 'vf610_gpio_probe':
> drivers/gpio/gpio-vf610.c:340:9: error: implicit declaration of function 'gpio_irq_chip_set_chip'
>
> Also affects v5.10.y and v5.15.y.

Thanks, I'll go drop the offending patches from all of these trees now
and push out some -rc2 releases.

greg k-h

2023-10-24 08:28:58

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/123] 5.4.259-rc1 review

On Mon, Oct 23, 2023 at 09:53:08AM -0600, Daniel D?az wrote:
> Same problems on Arm 32-bits as with 5.10 and 5.15:
>
> -----8<-----
> /builds/linux/drivers/gpio/gpio-vf610.c:249:11: error: use of undeclared identifier 'IRQCHIP_IMMUTABLE'
> 249 | .flags = IRQCHIP_IMMUTABLE | IRQCHIP_MASK_ON_SUSPEND
> | ^
> /builds/linux/drivers/gpio/gpio-vf610.c:250:6: error: use of undeclared identifier 'IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND'
> 250 | | IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND,
> | ^
> /builds/linux/drivers/gpio/gpio-vf610.c:251:2: error: use of undeclared identifier 'GPIOCHIP_IRQ_RESOURCE_HELPERS'
> 251 | GPIOCHIP_IRQ_RESOURCE_HELPERS,
> | ^
> /builds/linux/drivers/gpio/gpio-vf610.c:340:2: error: implicit declaration of function 'gpio_irq_chip_set_chip' [-Werror,-Wimplicit-function-declaration]
> 340 | gpio_irq_chip_set_chip(girq, &vf610_irqchip);
> | ^
> 4 errors generated.
> make[3]: *** [/builds/linux/scripts/Makefile.build:262: drivers/gpio/gpio-vf610.o] Error 1
> make[3]: Target '__build' not remade because of errors.
> make[2]: *** [/builds/linux/scripts/Makefile.build:497: drivers/gpio] Error 2

Now fixed up, thanks.


> /builds/linux/drivers/gpu/drm/drm_lock.c:363:6: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
> 363 | */ mutex_lock(&dev->struct_mutex);
> | ^
> /builds/linux/drivers/gpu/drm/drm_lock.c:357:2: note: previous statement is here
> 357 | if (!drm_core_check_feature(dev, DRIVER_LEGACY))
> | ^
> 1 warning generated.
> ----->8-----

This can't be a new warning as no patches in this -rc touch this file,
right?

thanks,

greg k-h

2023-10-24 08:57:15

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/123] 5.4.259-rc1 review

Hi Greg,

On Mon, Oct 23, 2023 at 12:55:58PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.259 release.
> There are 123 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000.
> Anything received after that time might be too late.

Build test (gcc version 11.3.1 20230511):
mips: 65 configs -> no failure
arm: 106 configs -> failed
arm64: 2 configs -> no failure
x86_64: 4 configs -> no failure
alpha allmodconfig -> no failure
powerpc allmodconfig -> no failure
riscv allmodconfig -> no failure
s390 allmodconfig -> no failure
xtensa allmodconfig -> no failure

Note:
arm builds are failing with the error:
drivers/gpio/gpio-vf610.c:251:9: error: 'GPIOCHIP_IRQ_RESOURCE_HELPERS' undeclared here (not in a function)
251 | GPIOCHIP_IRQ_RESOURCE_HELPERS,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpio/gpio-vf610.c:251:9: warning: excess elements in struct initializer
drivers/gpio/gpio-vf610.c:251:9: note: (near initialization for 'vf610_irqchip')
drivers/gpio/gpio-vf610.c: In function 'vf610_gpio_probe':
drivers/gpio/gpio-vf610.c:340:9: error: implicit declaration of function 'gpio_irq_chip_set_chip' [-Werror=implicit-function-declaration]
340 | gpio_irq_chip_set_chip(girq, &vf610_irqchip);
| ^~~~~~~~~~~~~~~~~~~~~~

Boot test:
x86_64: Booted on my test laptop. No regression.
x86_64: Booted on qemu. No regression. [1]

[1]. https://openqa.qa.codethink.co.uk/tests/5353


Tested-by: Sudip Mukherjee <[email protected]>

--
Regards
Sudip

2023-10-25 18:58:20

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/123] 5.4.259-rc1 review

On Mon, 23 Oct 2023 12:55:58 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.259 release.
> There are 123 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.259-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

All tests passing for Tegra ...

Test results for stable-v5.4:
10 builds: 10 pass, 0 fail
24 boots: 24 pass, 0 fail
54 tests: 54 pass, 0 fail

Linux version: 5.4.259-rc1-ga8161789be4b
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra210-p3450-0000,
tegra30-cardhu-a04

Tested-by: Jon Hunter <[email protected]>

Jon