2007-11-27 21:28:41

by Divy Le ray

[permalink] [raw]
Subject: [PATCH 0/3] cxgb - driver fixes.

Jeff,

I'm submitting a patch series for inclusion in 2.6.24 for the cxgb driver.
The patches are built against Linus'git tree.

Here is a brief description:
- Ensure that GSO skbs have enough headroom before encapsulating them,
- Fix a crash in NAPI mode,
- Fix statistics accounting and report.

Cheers,
Divy



2007-11-29 18:26:08

by Ben Greear

[permalink] [raw]
Subject: Re: [PATCH 0/3] cxgb - driver fixes.

Divy Le Ray wrote:
> Jeff,
>
> I'm submitting a patch series for inclusion in 2.6.24 for the cxgb driver.
> The patches are built against Linus'git tree.
>
> Here is a brief description:
> - Ensure that GSO skbs have enough headroom before encapsulating them,
> - Fix a crash in NAPI mode,
> - Fix statistics accounting and report.

We ran pktgen overnight on 2.6.23 with patch 1 and 3 applied (patch 2
not needed on .23 it seems) and it was stable at about 1.5Gbps bi-directional
using 1500 MTU sized frames.

We'll run some more tests with user-space TCP & UDP today, but it looks good
so far.

Perhaps these patches should be considered for .23 stable as well?

Thanks,
Ben

--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com

2007-12-01 23:26:52

by Divy Le ray

[permalink] [raw]
Subject: Re: [PATCH 0/3] cxgb - driver fixes.

Ben Greear wrote:
> Divy Le Ray wrote:
>> Jeff,
>>
>> I'm submitting a patch series for inclusion in 2.6.24 for the cxgb
>> driver.
>> The patches are built against Linus'git tree.
>>
>> Here is a brief description:
>> - Ensure that GSO skbs have enough headroom before encapsulating them,
>> - Fix a crash in NAPI mode,
>> - Fix statistics accounting and report.
>
> We ran pktgen overnight on 2.6.23 with patch 1 and 3 applied (patch 2
> not needed on .23 it seems) and it was stable at about 1.5Gbps
> bi-directional
> using 1500 MTU sized frames.
>
> We'll run some more tests with user-space TCP & UDP today, but it
> looks good
> so far.
>
> Perhaps these patches should be considered for .23 stable as well?
>
> Thanks,
> Ben
>

Yes, patches 1 and 3 could be considered for .22 and .23-stable, along
with the previous fix:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7de6af0f23b25df8da9719ecae1916b669d0b03d

Cheers,
Divy

2007-12-11 22:52:31

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 0/3] cxgb - driver fixes.

On Sat, Dec 01, 2007 at 03:26:15PM -0800, Divy Le Ray wrote:
> Ben Greear wrote:
>> Divy Le Ray wrote:
>>> Jeff,
>>>
>>> I'm submitting a patch series for inclusion in 2.6.24 for the cxgb
>>> driver.
>>> The patches are built against Linus'git tree.
>>>
>>> Here is a brief description:
>>> - Ensure that GSO skbs have enough headroom before encapsulating them,
>>> - Fix a crash in NAPI mode,
>>> - Fix statistics accounting and report.
>>
>> We ran pktgen overnight on 2.6.23 with patch 1 and 3 applied (patch 2
>> not needed on .23 it seems) and it was stable at about 1.5Gbps
>> bi-directional
>> using 1500 MTU sized frames.
>>
>> We'll run some more tests with user-space TCP & UDP today, but it looks
>> good
>> so far.
>>
>> Perhaps these patches should be considered for .23 stable as well?
>>
>> Thanks,
>> Ben
>>
>
> Yes, patches 1 and 3 could be considered for .22 and .23-stable, along with
> the previous fix:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7de6af0f23b25df8da9719ecae1916b669d0b03d

Can you send all of the individual patches you wish to have applied to
the -stable tree to [email protected] so that we can properly determine
exactly which patches you are referring to?

Also, make sure they are already in Linus's tree before telling us about
them.

thanks,

greg k-h