2023-12-04 09:47:18

by Matti Lehtimäki

Subject: [PATCH] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys

Add touch keys which are handled in touchscreen driver.
Use KEY_APPSELECT for the left button because other devices use that
even though downstream kernel uses KEY_RECENT.

Signed-off-by: Matti Lehtimäki <[email protected]>
---
.../boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
index f516e0426bb9..8a2ba2aadf23 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -268,6 +268,13 @@ touchscreen@4a {
interrupt-parent = <&tlmm>;
interrupts = <17 IRQ_TYPE_LEVEL_LOW>;

+ linux,keycodes = <KEY_RESERVED
+ KEY_RESERVED
+ KEY_RESERVED
+ KEY_RESERVED
+ KEY_APPSELECT
+ KEY_BACK>;
+
pinctrl-names = "default";
pinctrl-0 = <&tsp_int_rst_default_state>;

--
2.40.1

2023-12-04 10:43:23

by Konrad Dybcio

Subject: Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys

On 4.12.2023 10:46, Matti Lehtimäki wrote:
> Add touch keys which are handled in touchscreen driver.
> Use KEY_APPSELECT for the left button because other devices use that
> even though downstream kernel uses KEY_RECENT.
>
> Signed-off-by: Matti Lehtimäki <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2023-12-04 18:42:05

by Luca Weiss

Subject: Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys

On Montag, 4. Dezember 2023 10:46:49 CET Matti Lehtim?ki wrote:
> Add touch keys which are handled in touchscreen driver.
> Use KEY_APPSELECT for the left button because other devices use that
> even though downstream kernel uses KEY_RECENT.
>
> Signed-off-by: Matti Lehtim?ki <[email protected]>
> ---
> .../boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts index
> f516e0426bb9..8a2ba2aadf23 100644
> --- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> @@ -268,6 +268,13 @@ touchscreen@4a {
> interrupt-parent = <&tlmm>;
> interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
>
> + linux,keycodes = <KEY_RESERVED
> + KEY_RESERVED
> + KEY_RESERVED
> + KEY_RESERVED
> + KEY_APPSELECT
> + KEY_BACK>;

Might be prettier like this since it's 6 items you're adding, not one long
property?

linux,keycodes = <KEY_RESERVED>,
<KEY_RESERVED>,
<KEY_RESERVED>,
<KEY_RESERVED>,
<KEY_APPSELECT>,
<KEY_BACK>;

Resulting dtb should be the same, so it's just a stylistic thing.

In any case:

Reviewed-by: Luca Weiss <[email protected]>

> +
> pinctrl-names = "default";
> pinctrl-0 = <&tsp_int_rst_default_state>;

2024-01-27 22:36:50

by Bjorn Andersson

Subject: Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys

On Mon, 04 Dec 2023 11:46:49 +0200, Matti Lehtimäki wrote:
> Add touch keys which are handled in touchscreen driver.
> Use KEY_APPSELECT for the left button because other devices use that
> even though downstream kernel uses KEY_RECENT.
>
>

Applied, thanks!

[1/1] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys
commit: ffb05e91b68bc58484b94b5d3d1aa8e559278fd6

Best regards,
--
Bjorn Andersson <[email protected]>