2023-12-07 08:32:12

by Neil Armstrong

Subject: [PATCH] soc: qcom: pmic_pdcharger_ulog: fix sparse warnings

Fix sparse warning by comverting values to le32() as expected
in the get_ulog_req_msg.hdr struct.

Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Neil Armstrong <[email protected]>
---
drivers/soc/qcom/pmic_pdcharger_ulog.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/qcom/pmic_pdcharger_ulog.c b/drivers/soc/qcom/pmic_pdcharger_ulog.c
index f1aaacf05005..238cd38589dc 100644
--- a/drivers/soc/qcom/pmic_pdcharger_ulog.c
+++ b/drivers/soc/qcom/pmic_pdcharger_ulog.c
@@ -54,9 +54,9 @@ static int pmic_pdcharger_ulog_request(struct pmic_pdcharger_ulog *pg)
{
struct get_ulog_req_msg req_msg = {
.hdr = {
- .owner = MSG_OWNER_CHG_ULOG,
- .type = MSG_TYPE_REQ_RESP,
- .opcode = GET_CHG_ULOG_REQ
+ .owner = cpu_to_le32(MSG_OWNER_CHG_ULOG),
+ .type = cpu_to_le32(MSG_TYPE_REQ_RESP),
+ .opcode = cpu_to_le32(GET_CHG_ULOG_REQ)
},
.log_size = MAX_ULOG_SIZE
};

---
base-commit: 8e00ce02066e8f6f1ad5eab49a2ede7bf7a5ef64
change-id: 20231207-topic-sm8x50-upstream-fix-pdcharger-ulog-sparse-51a4ca55a6b3

Best regards,
--
Neil Armstrong <[email protected]>

2023-12-07 14:50:55

by Andrew Halaney

Subject: Re: [PATCH] soc: qcom: pmic_pdcharger_ulog: fix sparse warnings

Hey Neil,

On Thu, Dec 07, 2023 at 09:31:54AM +0100, Neil Armstrong wrote:
> Fix sparse warning by comverting values to le32() as expected
> in the get_ulog_req_msg.hdr struct.
>
> Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Neil Armstrong <[email protected]>

I already sent this change (among two other small issues I found) over
at:

https://lore.kernel.org/linux-arm-msm/[email protected]/

Thanks,
Andrew