2023-12-20 06:02:59

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] PM: hibernate: repair Excess function parameter warning

Function swsusp_close() does not have any parameters, so remove the
description of parameter @exclusive to prevent this warning.

swap.c:1573: warning: Excess function parameter 'exclusive' description in 'swsusp_close'

Signed-off-by: Randy Dunlap <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Pavel Machek <[email protected]>
Cc: Len Brown <[email protected]>
Cc: [email protected]
---
kernel/power/swap.c | 1 -
1 file changed, 1 deletion(-)

diff -- a/kernel/power/swap.c b/kernel/power/swap.c
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -1566,7 +1566,6 @@ put:

/**
* swsusp_close - close resume device.
- * @exclusive: Close the resume device which is exclusively opened.
*/

void swsusp_close(void)


2023-12-20 18:22:26

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] PM: hibernate: repair Excess function parameter warning

On Wed, Dec 20, 2023 at 7:02 AM Randy Dunlap <[email protected]> wrote:
>
> Function swsusp_close() does not have any parameters, so remove the
> description of parameter @exclusive to prevent this warning.
>
> swap.c:1573: warning: Excess function parameter 'exclusive' description in 'swsusp_close'
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Pavel Machek <[email protected]>
> Cc: Len Brown <[email protected]>
> Cc: [email protected]
> ---
> kernel/power/swap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff -- a/kernel/power/swap.c b/kernel/power/swap.c
> --- a/kernel/power/swap.c
> +++ b/kernel/power/swap.c
> @@ -1566,7 +1566,6 @@ put:
>
> /**
> * swsusp_close - close resume device.
> - * @exclusive: Close the resume device which is exclusively opened.
> */
>
> void swsusp_close(void)

Applied (under a slightly edited subject) as 6.8 material, thanks!