2023-12-22 02:55:12

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warnings after merge of the drivers-x86 tree

Hi all,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/platform/x86/intel/pmc/arl.c:680:6: warning: no previous prototype for 'arl_d3_fixup' [-Wmissing-prototypes]
680 | void arl_d3_fixup(void)
| ^~~~~~~~~~~~
drivers/platform/x86/intel/pmc/arl.c:685:5: warning: no previous prototype for 'arl_resume' [-Wmissing-prototypes]
685 | int arl_resume(struct pmc_dev *pmcdev)
| ^~~~~~~~~~
drivers/platform/x86/intel/pmc/lnl.c:503:6: warning: no previous prototype for 'lnl_d3_fixup' [-Wmissing-prototypes]
503 | void lnl_d3_fixup(void)
| ^~~~~~~~~~~~
drivers/platform/x86/intel/pmc/lnl.c:509:5: warning: no previous prototype for 'lnl_resume' [-Wmissing-prototypes]
509 | int lnl_resume(struct pmc_dev *pmcdev)
| ^~~~~~~~~~

Introduced by commits

f34dcf397286 ("platform/x86/intel/pmc: Add Arrow Lake S support to intel_pmc_core driver")
119652b855e6 ("platform/x86/intel/pmc: Add Lunar Lake M support to intel_pmc_core driver")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (495.00 B)
OpenPGP digital signature

2023-12-22 14:11:00

by Hans de Goede

[permalink] [raw]
Subject: Re: linux-next: build warnings after merge of the drivers-x86 tree

Hi All,

On 12/22/23 03:54, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> drivers/platform/x86/intel/pmc/arl.c:680:6: warning: no previous prototype for 'arl_d3_fixup' [-Wmissing-prototypes]
> 680 | void arl_d3_fixup(void)
> | ^~~~~~~~~~~~
> drivers/platform/x86/intel/pmc/arl.c:685:5: warning: no previous prototype for 'arl_resume' [-Wmissing-prototypes]
> 685 | int arl_resume(struct pmc_dev *pmcdev)
> | ^~~~~~~~~~
> drivers/platform/x86/intel/pmc/lnl.c:503:6: warning: no previous prototype for 'lnl_d3_fixup' [-Wmissing-prototypes]
> 503 | void lnl_d3_fixup(void)
> | ^~~~~~~~~~~~
> drivers/platform/x86/intel/pmc/lnl.c:509:5: warning: no previous prototype for 'lnl_resume' [-Wmissing-prototypes]
> 509 | int lnl_resume(struct pmc_dev *pmcdev)
> | ^~~~~~~~~~
>
> Introduced by commits
>
> f34dcf397286 ("platform/x86/intel/pmc: Add Arrow Lake S support to intel_pmc_core driver")
> 119652b855e6 ("platform/x86/intel/pmc: Add Lunar Lake M support to intel_pmc_core driver")

Ravji, can you please submit some fixes for these ?

Please split out the fixes into one per file, then I'll squash
them into the original commits.

Stephen, thank you for reporting these.

Regards,

Hans