2024-01-11 01:48:32

by XueBing Chen

Subject: [PATCH] mfd: twl: Clean up errors in twl.h

Fix the following errors reported by checkpatch:

ERROR: space prohibited after that open parenthesis '('
ERROR: open brace '{' following function definitions go on the next line

Signed-off-by: chenxuebing <[email protected]>
---
include/linux/mfd/mcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/mcp.h b/include/linux/mfd/mcp.h
index fd5cafc77e8a..ed56c67bbbc7 100644
--- a/include/linux/mfd/mcp.h
+++ b/include/linux/mfd/mcp.h
@@ -53,7 +53,7 @@ int mcp_driver_register(struct mcp_driver *);
void mcp_driver_unregister(struct mcp_driver *);

#define mcp_get_drvdata(mcp) dev_get_drvdata(&(mcp)->attached_device)
-#define mcp_set_drvdata(mcp,d) dev_set_drvdata(&(mcp)->attached_device, d)
+#define mcp_set_drvdata(mcp, d) dev_set_drvdata(&(mcp)->attached_device, d)

static inline void *mcp_priv(struct mcp *mcp)
{
--
2.17.1

2024-01-11 11:38:12

by Lee Jones

Subject: Re: [PATCH] mfd: twl: Clean up errors in twl.h

The subject needs to be improved.

Succinctly explain what you're doing.

On Thu, 11 Jan 2024, chenxuebing wrote:

> Fix the following errors reported by checkpatch:
>
> ERROR: space prohibited after that open parenthesis '('
> ERROR: open brace '{' following function definitions go on the next line
>
> Signed-off-by: chenxuebing <[email protected]>

Is this your first or last name, or both?

> ---
> include/linux/mfd/mcp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mfd/mcp.h b/include/linux/mfd/mcp.h
> index fd5cafc77e8a..ed56c67bbbc7 100644
> --- a/include/linux/mfd/mcp.h
> +++ b/include/linux/mfd/mcp.h
> @@ -53,7 +53,7 @@ int mcp_driver_register(struct mcp_driver *);
> void mcp_driver_unregister(struct mcp_driver *);
>
> #define mcp_get_drvdata(mcp) dev_get_drvdata(&(mcp)->attached_device)
> -#define mcp_set_drvdata(mcp,d) dev_set_drvdata(&(mcp)->attached_device, d)
> +#define mcp_set_drvdata(mcp, d) dev_set_drvdata(&(mcp)->attached_device, d)

The code is fine, obviously.

> static inline void *mcp_priv(struct mcp *mcp)
> {
> --
> 2.17.1
>

--
Lee Jones [李琼斯]