2024-01-25 03:07:46

by Kunwu Chan

Subject: [PATCH] x86: Code cleanup for ehci_hdr

This part was commented from commit 3ef0e1f8cad0
("x86: olpc: add One Laptop Per Child architecture support")
in about 16 years before.

If there are no plans to enable this part code in the future,
we can remove this dead code.

Signed-off-by: Kunwu Chan <[email protected]>
---
arch/x86/pci/olpc.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/x86/pci/olpc.c b/arch/x86/pci/olpc.c
index f3aab76e357a..4b18c6404363 100644
--- a/arch/x86/pci/olpc.c
+++ b/arch/x86/pci/olpc.c
@@ -154,9 +154,6 @@ static const uint32_t ehci_hdr[] = { /* dev f function 4 - devfn = 7d */
0x0, 0x40, 0x0, 0x40a, /* CapPtr INT-D, IRQA */
0xc8020001, 0x0, 0x0, 0x0, /* Capabilities - 40 is R/O, 44 is
mask 8103 (power control) */
-#if 0
- 0x1, 0x40080000, 0x0, 0x0, /* EECP - see EHCI spec section 2.1.7 */
-#endif
0x01000001, 0x0, 0x0, 0x0, /* EECP - see EHCI spec section 2.1.7 */
0x2020, 0x0, 0x0, 0x0, /* (EHCI page 8) 60 SBRN (R/O),
61 FLADJ (R/W), PORTWAKECAP */
--
2.39.2

2024-05-03 22:13:05

by Bjorn Helgaas

Subject: Re: [PATCH] x86: Code cleanup for ehci_hdr

[+cc Andres, author of 3ef0e1f8cad0]

On Thu, Jan 25, 2024 at 11:06:23AM +0800, Kunwu Chan wrote:
> This part was commented from commit 3ef0e1f8cad0
> ("x86: olpc: add One Laptop Per Child architecture support")
> in about 16 years before.
>
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
>
> Signed-off-by: Kunwu Chan <[email protected]>

Applied to pci/misc for v6.10, thanks.

> ---
> arch/x86/pci/olpc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/pci/olpc.c b/arch/x86/pci/olpc.c
> index f3aab76e357a..4b18c6404363 100644
> --- a/arch/x86/pci/olpc.c
> +++ b/arch/x86/pci/olpc.c
> @@ -154,9 +154,6 @@ static const uint32_t ehci_hdr[] = { /* dev f function 4 - devfn = 7d */
> 0x0, 0x40, 0x0, 0x40a, /* CapPtr INT-D, IRQA */
> 0xc8020001, 0x0, 0x0, 0x0, /* Capabilities - 40 is R/O, 44 is
> mask 8103 (power control) */
> -#if 0
> - 0x1, 0x40080000, 0x0, 0x0, /* EECP - see EHCI spec section 2.1.7 */
> -#endif
> 0x01000001, 0x0, 0x0, 0x0, /* EECP - see EHCI spec section 2.1.7 */
> 0x2020, 0x0, 0x0, 0x0, /* (EHCI page 8) 60 SBRN (R/O),
> 61 FLADJ (R/W), PORTWAKECAP */
> --
> 2.39.2
>