2024-02-05 05:15:01

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warnings after merge of the kspp tree

Hi all,

After merging the kspp tree, today's linux-next build (htmldocs) produced
these warnings:

include/linux/overflow.h:97: warning: Function parameter or struct member 'var' not described in 'inc_wrap'
include/linux/overflow.h:97: warning: Function parameter or struct member 'offset' not described in 'inc_wrap'
include/linux/overflow.h:97: warning: Excess function parameter 'a' description in 'inc_wrap'
include/linux/overflow.h:97: warning: Excess function parameter 'b' description in 'inc_wrap'
include/linux/overflow.h:142: warning: Function parameter or struct member 'var' not described in 'dec_wrap'
include/linux/overflow.h:142: warning: Function parameter or struct member 'offset' not described in 'dec_wrap'
include/linux/overflow.h:142: warning: Excess function parameter 'a' description in 'dec_wrap'
include/linux/overflow.h:142: warning: Excess function parameter 'b' description in 'dec_wrap'

Introduced by commit

6ad835d8849c ("overflow: Introduce inc_wrap() and dec_wrap()")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2024-02-05 12:44:29

by Kees Cook

[permalink] [raw]
Subject: Re: linux-next: build warnings after merge of the kspp tree

On Mon, Feb 05, 2024 at 04:14:46PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the kspp tree, today's linux-next build (htmldocs) produced
> these warnings:
>
> include/linux/overflow.h:97: warning: Function parameter or struct member 'var' not described in 'inc_wrap'
> include/linux/overflow.h:97: warning: Function parameter or struct member 'offset' not described in 'inc_wrap'
> include/linux/overflow.h:97: warning: Excess function parameter 'a' description in 'inc_wrap'
> include/linux/overflow.h:97: warning: Excess function parameter 'b' description in 'inc_wrap'
> include/linux/overflow.h:142: warning: Function parameter or struct member 'var' not described in 'dec_wrap'
> include/linux/overflow.h:142: warning: Function parameter or struct member 'offset' not described in 'dec_wrap'
> include/linux/overflow.h:142: warning: Excess function parameter 'a' description in 'dec_wrap'
> include/linux/overflow.h:142: warning: Excess function parameter 'b' description in 'dec_wrap'
>
> Introduced by commit
>
> 6ad835d8849c ("overflow: Introduce inc_wrap() and dec_wrap()")

Eek, thanks! I've fixed and pushed this now.

--
Kees Cook