2024-02-10 22:15:40

by Youssef Quaisse

Subject: [PATCH] Fix three warnings when running `make htmldocs`

Running `make htmldocs` generates warnings for file
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h.

Fix was to remove the "excess" definitions.

Warnings in question:

```
/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h:2522: warning: Excess struct member 'reserved1' description in 'ipu3_uapi_acc_param'
/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h:2522: warning: Excess struct member 'reserved2' description in 'ipu3_uapi_acc_param'
/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h:2778: warning: Excess struct member '__acc_osys' description in 'ipu3_uapi_flags'
```

Signed-off-by: Youssef Quaisse <[email protected]>
---
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
index caa358e0bae4..4aa2797f5e3c 100644
--- a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
+++ b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
@@ -2485,11 +2485,9 @@ struct ipu3_uapi_anr_config {
* &ipu3_uapi_yuvp1_y_ee_nr_config
* @yds: y down scaler config. See &ipu3_uapi_yuvp1_yds_config
* @chnr: chroma noise reduction config. See &ipu3_uapi_yuvp1_chnr_config
- * @reserved1: reserved
* @yds2: y channel down scaler config. See &ipu3_uapi_yuvp1_yds_config
* @tcc: total color correction config as defined in struct
* &ipu3_uapi_yuvp2_tcc_static_config
- * @reserved2: reserved
* @anr: advanced noise reduction config.See &ipu3_uapi_anr_config
* @awb_fr: AWB filter response config. See ipu3_uapi_awb_fr_config
* @ae: auto exposure config As specified by &ipu3_uapi_ae_config
@@ -2724,7 +2722,6 @@ struct ipu3_uapi_obgrid_param {
* @acc_ae: 0 = no update, 1 = update.
* @acc_af: 0 = no update, 1 = update.
* @acc_awb: 0 = no update, 1 = update.
- * @__acc_osys: 0 = no update, 1 = update.
* @reserved3: Not used.
* @lin_vmem_params: 0 = no update, 1 = update.
* @tnr3_vmem_params: 0 = no update, 1 = update.
--
2.43.0

2024-02-14 11:05:35

by Sakari Ailus

Subject: Re: [PATCH] Fix three warnings when running `make htmldocs`

Hi Youssef,

On Sat, Feb 10, 2024 at 10:14:38PM +0000, Youssef Quaisse wrote:
> Running `make htmldocs` generates warnings for file
> drivers/staging/media/ipu3/include/uapi/intel-ipu3.h.
>
> Fix was to remove the "excess" definitions.
>
> Warnings in question:
>
> ```
> ./drivers/staging/media/ipu3/include/uapi/intel-ipu3.h:2522: warning: Excess struct member 'reserved1' description in 'ipu3_uapi_acc_param'
> ./drivers/staging/media/ipu3/include/uapi/intel-ipu3.h:2522: warning: Excess struct member 'reserved2' description in 'ipu3_uapi_acc_param'
> ./drivers/staging/media/ipu3/include/uapi/intel-ipu3.h:2778: warning: Excess struct member '__acc_osys' description in 'ipu3_uapi_flags'
> ```
>
> Signed-off-by: Youssef Quaisse <[email protected]>

Thanks for the patch. These have been already addressed by commit
dcef3ed5b0d79f89018e31d55cf09f2c2f81392b .

> ---
> drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
> index caa358e0bae4..4aa2797f5e3c 100644
> --- a/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
> +++ b/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h
> @@ -2485,11 +2485,9 @@ struct ipu3_uapi_anr_config {
> * &ipu3_uapi_yuvp1_y_ee_nr_config
> * @yds: y down scaler config. See &ipu3_uapi_yuvp1_yds_config
> * @chnr: chroma noise reduction config. See &ipu3_uapi_yuvp1_chnr_config
> - * @reserved1: reserved
> * @yds2: y channel down scaler config. See &ipu3_uapi_yuvp1_yds_config
> * @tcc: total color correction config as defined in struct
> * &ipu3_uapi_yuvp2_tcc_static_config
> - * @reserved2: reserved
> * @anr: advanced noise reduction config.See &ipu3_uapi_anr_config
> * @awb_fr: AWB filter response config. See ipu3_uapi_awb_fr_config
> * @ae: auto exposure config As specified by &ipu3_uapi_ae_config
> @@ -2724,7 +2722,6 @@ struct ipu3_uapi_obgrid_param {
> * @acc_ae: 0 = no update, 1 = update.
> * @acc_af: 0 = no update, 1 = update.
> * @acc_awb: 0 = no update, 1 = update.
> - * @__acc_osys: 0 = no update, 1 = update.
> * @reserved3: Not used.
> * @lin_vmem_params: 0 = no update, 1 = update.
> * @tnr3_vmem_params: 0 = no update, 1 = update.

--
Kind regards,

Sakari Ailus