2024-02-16 14:03:34

by Colin Ian King

Subject: [PATCH][next] clk: cdce925: Remove redundant assignment to variable 'rate'

The variable 'rate' being assigned a value that is never read, the
assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/clk/clk-cdce925.c:104:3: warning: Value stored to 'rate' is
never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/clk/clk-cdce925.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c
index b0122093c6ff..e48be7a6c0e2 100644
--- a/drivers/clk/clk-cdce925.c
+++ b/drivers/clk/clk-cdce925.c
@@ -101,7 +101,6 @@ static void cdce925_pll_find_rate(unsigned long rate,

if (rate <= parent_rate) {
/* Can always deliver parent_rate in bypass mode */
- rate = parent_rate;
*n = 0;
*m = 0;
} else {
--
2.39.2

2024-02-22 05:36:25

by Stephen Boyd

Subject: Re: [PATCH][next] clk: cdce925: Remove redundant assignment to variable 'rate'

Quoting Colin Ian King (2024-02-16 06:01:32)
> The variable 'rate' being assigned a value that is never read, the
> assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/clk/clk-cdce925.c:104:3: warning: Value stored to 'rate' is
> never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---

Applied to clk-next