2008-01-03 01:36:39

by Yinghai Lu

Subject: [PATCH] x86_64: not clear empty_zero_page again

[PATCH] x86_64: not clear empty_zero_page again

empty_zero_page is in .bss section, and it is cleared in clear_bss by x86_64_start_kernel. So don't clear that again in mem_init

Signed-off-by: Yinghai Lu <[email protected]>

Index: linux-2.6/arch/x86/mm/init_64.c
===================================================================
--- linux-2.6.orig/arch/x86/mm/init_64.c
+++ linux-2.6/arch/x86/mm/init_64.c
@@ -521,8 +521,7 @@ void __init mem_init(void)

pci_iommu_alloc();

- /* clear the zero-page */
- memset(empty_zero_page, 0, PAGE_SIZE);
+ /* clear_bss() already clear the empty_zero_page */

reservedpages = 0;

2008-01-03 08:45:53

by Ingo Molnar

Subject: Re: [PATCH] x86_64: not clear empty_zero_page again

* Yinghai Lu <[email protected]> wrote:

> [PATCH] x86_64: not clear empty_zero_page again
>
> empty_zero_page is in .bss section, and it is cleared in clear_bss by
> x86_64_start_kernel. So don't clear that again in mem_init

thanks, applied.

Ingo