2024-02-29 23:01:50

by Colin Ian King

Subject: [PATCH][next] vboxsf: remove redundant variable out_len

The variable out_len is being used to accumulate the number of
bytes but it is not being used for any other purpose. The variable
is redundant and can be removed.

Cleans up clang scan build warning:
fs/vboxsf/utils.c:443:9: warning: variable 'out_len' set but not
used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <[email protected]>
---
fs/vboxsf/utils.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/fs/vboxsf/utils.c b/fs/vboxsf/utils.c
index 72ac9320e6a3..9515bbf0b54c 100644
--- a/fs/vboxsf/utils.c
+++ b/fs/vboxsf/utils.c
@@ -440,7 +440,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
{
const char *in;
char *out;
- size_t out_len;
size_t out_bound_len;
size_t in_bound_len;

@@ -448,7 +447,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
in_bound_len = utf8_len;

out = name;
- out_len = 0;
/* Reserve space for terminating 0 */
out_bound_len = name_bound_len - 1;

@@ -469,7 +467,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,

out += nb;
out_bound_len -= nb;
- out_len += nb;
}

*out = 0;
--
2.39.2

2024-04-03 14:12:50

by Hans de Goede

Subject: Re: [PATCH][next] vboxsf: remove redundant variable out_len

Hi,

On 2/29/24 11:51 PM, Colin Ian King wrote:
> The variable out_len is being used to accumulate the number of
> bytes but it is not being used for any other purpose. The variable
> is redundant and can be removed.
>
> Cleans up clang scan build warning:
> fs/vboxsf/utils.c:443:9: warning: variable 'out_len' set but not
> used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

I have added this to my local vboxsf branch now and I'll send
out a pull-request with this and a couple of other vboxsf fixes
soon.

Regards,

Hans



> ---
> fs/vboxsf/utils.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/vboxsf/utils.c b/fs/vboxsf/utils.c
> index 72ac9320e6a3..9515bbf0b54c 100644
> --- a/fs/vboxsf/utils.c
> +++ b/fs/vboxsf/utils.c
> @@ -440,7 +440,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
> {
> const char *in;
> char *out;
> - size_t out_len;
> size_t out_bound_len;
> size_t in_bound_len;
>
> @@ -448,7 +447,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
> in_bound_len = utf8_len;
>
> out = name;
> - out_len = 0;
> /* Reserve space for terminating 0 */
> out_bound_len = name_bound_len - 1;
>
> @@ -469,7 +467,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
>
> out += nb;
> out_bound_len -= nb;
> - out_len += nb;
> }
>
> *out = 0;