2024-03-13 09:08:04

by Yuu Lee

Subject: [PATCH] locking/mutex: fix documentation spelling mistakes

fix 'task_strcut' to 'task_struct'

Signed-off-by: Yuu Lee <[email protected]>
---
kernel/locking/mutex.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
index cbae8c0b8..82d19846e 100644
--- a/kernel/locking/mutex.c
+++ b/kernel/locking/mutex.c
@@ -362,7 +362,7 @@ bool mutex_spin_on_owner(struct mutex *lock, struct task_struct *owner,
* checking lock->owner still matches owner. And we already
* disabled preemption which is equal to the RCU read-side
* crital section in optimistic spinning code. Thus the
- * task_strcut structure won't go away during the spinning
+ * task_struct structure won't go away during the spinning
* period
*/
barrier();
@@ -401,7 +401,7 @@ static inline int mutex_can_spin_on_owner(struct mutex *lock)

/*
* We already disabled preemption which is equal to the RCU read-side
- * crital section in optimistic spinning code. Thus the task_strcut
+ * crital section in optimistic spinning code. Thus the task_struct
* structure won't go away during the spinning period.
*/
owner = __mutex_owner(lock);
--
2.41.0

2024-03-13 10:23:04

by Ingo Molnar

Subject: Re: [PATCH] locking/mutex: fix documentation spelling mistakes

* Yuu Lee <[email protected]> wrote:

> fix 'task_strcut' to 'task_struct'
>
> Signed-off-by: Yuu Lee <[email protected]>
> ---
> kernel/locking/mutex.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
> index cbae8c0b8..82d19846e 100644
> --- a/kernel/locking/mutex.c
> +++ b/kernel/locking/mutex.c
> @@ -362,7 +362,7 @@ bool mutex_spin_on_owner(struct mutex *lock, struct task_struct *owner,
> * checking lock->owner still matches owner. And we already
> * disabled preemption which is equal to the RCU read-side
> * crital section in optimistic spinning code. Thus the
> - * task_strcut structure won't go away during the spinning
> + * task_struct structure won't go away during the spinning
> * period
> */
> barrier();
> @@ -401,7 +401,7 @@ static inline int mutex_can_spin_on_owner(struct mutex *lock)
>
> /*
> * We already disabled preemption which is equal to the RCU read-side
> - * crital section in optimistic spinning code. Thus the task_strcut
> + * crital section in optimistic spinning code. Thus the task_struct
> * structure won't go away during the spinning period.

There's another typo here, which you might as well fix?

Thanks,

Ingo