On Mon, Mar 18, 2024 at 09:09:53PM +0530, Animesh Agarwal wrote:
> diff --git a/Documentation/devicetree/bindings/i2c/nxp,pnx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nxp,pnx-i2c.yaml
> new file mode 100644
> index 000000000000..3125b2f5891e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/nxp,pnx-i2c.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/nxp,pnx-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP PNX I2C Controller
> +
> +maintainers:
> + - Animesh Agarwal<[email protected]>
You're missing a space before the <, but otherwise this looks fine.
Reviewed-by: Conor Dooley <[email protected]>
Thanks,
Conor.
On Tue, Mar 19, 2024 at 11:27 PM Conor Dooley <[email protected]> wrote:
> You're missing a space before the <, but otherwise this looks fine.
Should I send another version fixing this issue?
> Reviewed-by: Conor Dooley <[email protected]>
Thanks for the review.
Regards,
Animesh.
On 20/03/2024 01:53, Animesh Agarwal wrote:
> On Tue, Mar 19, 2024 at 11:27 PM Conor Dooley <[email protected]> wrote:
>
>> You're missing a space before the <, but otherwise this looks fine.
>
> Should I send another version fixing this issue?
>
Yes.
While at this:
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
missing i2c
---
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
On Wed, Mar 20, 2024 at 1:23 PM Krzysztof Kozlowski
<[email protected]> wrote:
> Yes.
>
> While at this:
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
> missing i2c
Thanks for the support on this, I will be using proper subject
prefixes here onwards.
> This is an automated instruction, just in case, because many review tags
> are being ignored. If you know the process, you can skip it (please do
> not feel offended by me posting it here - no bad intentions intended).
> If you do not know the process, here is a short explanation:
>
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
Yes, I'll follow these instructions for v3 of this patch.
Regards,
Animesh Agarwal