2024-03-22 13:22:18

by Arnd Bergmann

Subject: [PATCH] pinctrl: armada-37xx: remove an unused variable

From: Arnd Bergmann <[email protected]>

This variable has never been used and can be removed to avoid a W=1 warning:

drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:837:6: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
837 | int i = 0;

Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index c34719b7506d..4c4ada06423d 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -834,8 +834,6 @@ static int armada_37xx_gpiochip_register(struct platform_device *pdev,
static int armada_37xx_add_function(struct armada_37xx_pmx_func *funcs,
int *funcsize, const char *name)
{
- int i = 0;
-
if (*funcsize <= 0)
return -EOVERFLOW;

@@ -847,7 +845,6 @@ static int armada_37xx_add_function(struct armada_37xx_pmx_func *funcs,
return -EEXIST;
}
funcs++;
- i++;
}

/* append new unique function */
--
2.39.2

2024-03-22 14:40:00

by Andrew Lunn

Subject: Re: [PATCH] pinctrl: armada-37xx: remove an unused variable

On Fri, Mar 22, 2024 at 02:21:43PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> This variable has never been used and can be removed to avoid a W=1 warning:
>
> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:837:6: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
> 837 | int i = 0;
>
> Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx")
> Signed-off-by: Arnd Bergmann <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2024-04-02 12:27:57

by Linus Walleij

Subject: Re: [PATCH] pinctrl: armada-37xx: remove an unused variable

On Fri, Mar 22, 2024 at 2:22 PM Arnd Bergmann <[email protected]> wrote:

> From: Arnd Bergmann <[email protected]>
>
> This variable has never been used and can be removed to avoid a W=1 warning:
>
> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:837:6: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
> 837 | int i = 0;
>
> Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx")
> Signed-off-by: Arnd Bergmann <[email protected]>

Patch applied!

Yours,
Linus Walleij