2024-03-22 13:22:49

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] coda: avoid Wunused-but-set-variable warning

From: Arnd Bergmann <[email protected]>

The UPARG() macro implicitly sets the outp variable, but a lot of the
callers never actually use the results instead, causing a W=1 warning:

fs/coda/upcall.c:115:27: error: variable 'outp' set but not used [-Werror,-Wunused-but-set-variable]
115 | union outputArgs *outp;
| ^

Add a cast to void to shut up that warning for callers that don't
care bout the output.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Arnd Bergmann <[email protected]>
---
fs/coda/upcall.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c
index cd6a3721f6f6..b7451fdef14d 100644
--- a/fs/coda/upcall.c
+++ b/fs/coda/upcall.c
@@ -63,6 +63,7 @@ do {\
inp = (union inputArgs *)alloc_upcall(op, insize); \
if (IS_ERR(inp)) { return PTR_ERR(inp); }\
outp = (union outputArgs *)(inp); \
+ (void)outp; \
outsize = insize; \
} while (0)

--
2.39.2