2024-03-31 08:49:15

by Krzysztof Kozlowski

[permalink] [raw]

Subject: [PATCH v2 06/25] virtio_blk: drop owner assignment

---

virtio core already sets the .owner, so driver does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Depends on the first patch.
---
drivers/block/virtio_blk.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 42dea7601d87..46bdbad1ab48 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -1658,7 +1658,6 @@ static struct virtio_driver virtio_blk = {
.feature_table_legacy = features_legacy,
.feature_table_size_legacy = ARRAY_SIZE(features_legacy),
.driver.name = KBUILD_MODNAME,
- .driver.owner = THIS_MODULE,
.id_table = id_table,
.probe = virtblk_probe,
.remove = virtblk_remove,

--
2.34.1

2024-04-02 20:33:53

by Stefan Hajnoczi

[permalink] [raw]

Subject: Re: [PATCH v2 06/25] virtio_blk: drop owner assignment

---

On Sun, Mar 31, 2024 at 10:43:53AM +0200, Krzysztof Kozlowski wrote:
> virtio core already sets the .owner, so driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Depends on the first patch.
> ---
> drivers/block/virtio_blk.c | 1 -
> 1 file changed, 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <[email protected]>

---

Attachments:

(No filename) (391.00 B)
signature.asc (499.00 B)
Download all attachments