dlserver is started when a cfs task is enqueued to an empty runqueue.
Similarly dlserver is stopped when the last cfs task is dequeued. But
this logic doesn't take care of the cfs throttling scenarios where the
root cfs runqueue's h_nr_running stays zero while enqueue/dequeue can
happen on throttled runqueues. This causes duplicate calls to start/stop
and causes issues with deadline logic. One example is a WARN_ON in
task_non_contending because of duplicate calls to dl_server_stop().
WARNING kernel: [ 1970.747755] ------------[ cut here ]------------
WARNING kernel: [ 1970.747767] WARNING: CPU: 0 PID: 14202 at kernel/sched/deadline.c:352 task_non_contending+0x404/0x500
WARNING kernel: [ 1970.747868] CPU: 0 PID: 14202 Comm: tpm_manager_cli Tainted: G W 5.15.152-22017-ga797d64dcd15 #1
WARNING kernel: [ 1970.747874] Hardware name: HP Meep/Meep, BIOS Google_Meep.11297.250.0 01/25/2021
WARNING kernel: [ 1970.747877] RIP: 0010:task_non_contending+0x404/0x500
WARNING kernel: [ 1970.747910] Call Trace:
WARNING kernel: [ 1970.747914] <TASK>
WARNING kernel: [ 1970.747918] ? __warn+0xa3/0x131
WARNING kernel: [ 1970.747923] ? task_non_contending+0x404/0x500
WARNING kernel: [ 1970.747927] ? report_bug+0x97/0xfa
WARNING kernel: [ 1970.747932] ? handle_bug+0x41/0x66
WARNING kernel: [ 1970.747937] ? exc_invalid_op+0x1b/0x4b
WARNING kernel: [ 1970.747941] ? asm_exc_invalid_op+0x16/0x20
WARNING kernel: [ 1970.747946] ? task_non_contending+0x404/0x500
WARNING kernel: [ 1970.747949] ? dequeue_dl_entity+0x112/0x2cd
WARNING kernel: [ 1970.747952] dl_server_stop+0x17/0x2b
WARNING kernel: [ 1970.747956] dequeue_task_fair+0x262/0x4c4
WARNING kernel: [ 1970.747962] __schedule+0x17c/0xf13
WARNING kernel: [ 1970.747966] ? update_load_avg+0x9b/0x611
WARNING kernel: [ 1970.747970] schedule+0x4e/0xd0
WARNING kernel: [ 1970.747974] schedule_hrtimeout_range_clock+0x10f/0x126
WARNING kernel: [ 1970.747977] ? add_wait_queue+0x4d/0x84
WARNING kernel: [ 1970.747982] poll_schedule_timeout+0x33/0x50
WARNING kernel: [ 1970.747987] do_sys_poll+0x4a3/0x626
WARNING kernel: [ 1970.747993] ? __se_sys_ppoll+0xdf/0xdf
WARNING kernel: [ 1970.748000] __se_sys_poll+0x70/0xf7
WARNING kernel: [ 1970.748003] do_syscall_64+0x51/0xa1
WARNING kernel: [ 1970.748007] entry_SYSCALL_64_after_hwframe+0x5c/0xc6
WARNING kernel: [ 1970.748012] RIP: 0033:0x7bc815769510
dlserver should be started on an idle root cfs rq, when
- enqueue on a non-throttled cfs_rq causing the root cfs rq to
go non-idle, or
- untthrottle results in the root cfs rq to go non-idle.
Similarly dlserver should be stopped on a non-idle root cfs rq, when
- dequeue on a non-throttled cfs_rq causing the root cfs rq to
go idle, or
- throttle results in the root cfs rq to go idle.
This patch also adds a flag to track the state of the dlserver(active or
not) to catch bugs which causes similar duplicate start/stops. This
alone will fix the issue actually, but I feel we need the caller to be
responsible not to make duplicate calls.
BUG=b:332187250
TEST=tast run brya ui.DocsCUJ.field_trials
Change-Id: Iafe463ca76d1ec08f9588bf825df23a151591e96
Signed-off-by: Vineeth Pillai (Google) <[email protected]>
---
include/linux/sched.h | 1 +
kernel/sched/deadline.c | 9 +++++++++
kernel/sched/fair.c | 22 ++++++++++++++++++++--
3 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index b0a5983cf3d1..fe5e39006188 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -646,6 +646,7 @@ struct sched_dl_entity {
unsigned int dl_defer : 1;
unsigned int dl_defer_armed : 1;
unsigned int dl_defer_running : 1;
+ unsigned int dl_server_active : 1;
/*
* Bandwidth enforcement timer. Each -deadline task has its
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index f0a7f0e43ff0..bda964ac8d7c 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1642,13 +1642,18 @@ void dl_server_start(struct sched_dl_entity *dl_se)
dl_se->dl_server = 1;
dl_se->dl_defer = 1;
+ dl_se->dl_server_active = 0;
setup_new_dl_entity(dl_se);
}
if (!dl_se->dl_runtime)
return;
+ if (WARN_ON_ONCE(dl_se->dl_server_active))
+ return;
+
enqueue_dl_entity(dl_se, ENQUEUE_WAKEUP);
+ dl_se->dl_server_active = 1;
if (!dl_task(dl_se->rq->curr) || dl_entity_preempt(dl_se, &rq->curr->dl))
resched_curr(dl_se->rq);
}
@@ -1658,10 +1663,14 @@ void dl_server_stop(struct sched_dl_entity *dl_se)
if (!dl_se->dl_runtime)
return;
+ if (WARN_ON_ONCE(!dl_se->dl_server_active))
+ return;
+
dequeue_dl_entity(dl_se, DEQUEUE_SLEEP);
hrtimer_try_to_cancel(&dl_se->dl_timer);
dl_se->dl_defer_armed = 0;
dl_se->dl_throttled = 0;
+ dl_se->dl_server_active = 0;
}
void dl_server_init(struct sched_dl_entity *dl_se, struct rq *rq,
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b86bb3f23fb2..c11f872bb196 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5765,6 +5765,7 @@ static bool throttle_cfs_rq(struct cfs_rq *cfs_rq)
struct cfs_bandwidth *cfs_b = tg_cfs_bandwidth(cfs_rq->tg);
struct sched_entity *se;
long task_delta, idle_task_delta, dequeue = 1;
+ long rq_h_nr_running = rq->cfs.h_nr_running;
raw_spin_lock(&cfs_b->lock);
/* This will start the period timer if necessary */
@@ -5837,6 +5838,13 @@ static bool throttle_cfs_rq(struct cfs_rq *cfs_rq)
sub_nr_running(rq, task_delta);
done:
+ /*
+ * Stop the dlserver if throttling resulted in no runnable
+ * tasks.
+ */
+ if (rq_h_nr_running && !rq->cfs.h_nr_running)
+ dl_server_stop(&rq->fair_server);
+
/*
* Note: distribution will already see us throttled via the
* throttled-list. rq->lock protects completion.
@@ -5854,6 +5862,7 @@ void unthrottle_cfs_rq(struct cfs_rq *cfs_rq)
struct cfs_bandwidth *cfs_b = tg_cfs_bandwidth(cfs_rq->tg);
struct sched_entity *se;
long task_delta, idle_task_delta;
+ long rq_h_nr_running = rq->cfs.h_nr_running;
se = cfs_rq->tg->se[cpu_of(rq)];
@@ -5929,6 +5938,13 @@ void unthrottle_cfs_rq(struct cfs_rq *cfs_rq)
unthrottle_throttle:
assert_list_leaf_cfs_rq(rq);
+ /*
+ * Start the dlserver if un-throttling resulted in new runnable
+ * tasks.
+ */
+ if (!rq_h_nr_running && rq->cfs.h_nr_running)
+ dl_server_start(&rq->fair_server);
+
/* Determine whether we need to wake up potentially idle CPU: */
if (rq->curr == rq->idle && rq->cfs.nr_running)
resched_curr(rq);
@@ -6734,7 +6750,8 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
*/
util_est_enqueue(&rq->cfs, p);
- if (!rq->cfs.h_nr_running) {
+ if (!throttled_hierarchy(task_cfs_rq(p)) &&
+ !rq->cfs.h_nr_running) {
/* Account for idle runtime */
if (!rq->nr_running)
dl_server_update_idle_time(rq, rq->curr);
@@ -6885,7 +6902,8 @@ static void dequeue_task_fair(struct rq *rq, struct task_struct *p, int flags)
rq->next_balance = jiffies;
dequeue_throttle:
- if (!rq->cfs.h_nr_running)
+ if (!throttled_hierarchy(task_cfs_rq(p)) &&
+ !rq->cfs.h_nr_running)
dl_server_stop(&rq->fair_server);
util_est_update(&rq->cfs, p, task_sleep);
--
2.40.1
On 4/12/24 21:23, Vineeth Pillai (Google) wrote:
> dlserver is started when a cfs task is enqueued to an empty runqueue.
> Similarly dlserver is stopped when the last cfs task is dequeued. But
> this logic doesn't take care of the cfs throttling scenarios where the
> root cfs runqueue's h_nr_running stays zero while enqueue/dequeue can
> happen on throttled runqueues. This causes duplicate calls to start/stop
> and causes issues with deadline logic. One example is a WARN_ON in
> task_non_contending because of duplicate calls to dl_server_stop().
>
> WARNING kernel: [ 1970.747755] ------------[ cut here ]------------
> WARNING kernel: [ 1970.747767] WARNING: CPU: 0 PID: 14202 at kernel/sched/deadline.c:352 task_non_contending+0x404/0x500
>
> WARNING kernel: [ 1970.747868] CPU: 0 PID: 14202 Comm: tpm_manager_cli Tainted: G W 5.15.152-22017-ga797d64dcd15 #1
> WARNING kernel: [ 1970.747874] Hardware name: HP Meep/Meep, BIOS Google_Meep.11297.250.0 01/25/2021
> WARNING kernel: [ 1970.747877] RIP: 0010:task_non_contending+0x404/0x500
>
> WARNING kernel: [ 1970.747910] Call Trace:
> WARNING kernel: [ 1970.747914] <TASK>
> WARNING kernel: [ 1970.747918] ? __warn+0xa3/0x131
> WARNING kernel: [ 1970.747923] ? task_non_contending+0x404/0x500
> WARNING kernel: [ 1970.747927] ? report_bug+0x97/0xfa
> WARNING kernel: [ 1970.747932] ? handle_bug+0x41/0x66
> WARNING kernel: [ 1970.747937] ? exc_invalid_op+0x1b/0x4b
> WARNING kernel: [ 1970.747941] ? asm_exc_invalid_op+0x16/0x20
> WARNING kernel: [ 1970.747946] ? task_non_contending+0x404/0x500
> WARNING kernel: [ 1970.747949] ? dequeue_dl_entity+0x112/0x2cd
> WARNING kernel: [ 1970.747952] dl_server_stop+0x17/0x2b
> WARNING kernel: [ 1970.747956] dequeue_task_fair+0x262/0x4c4
> WARNING kernel: [ 1970.747962] __schedule+0x17c/0xf13
> WARNING kernel: [ 1970.747966] ? update_load_avg+0x9b/0x611
> WARNING kernel: [ 1970.747970] schedule+0x4e/0xd0
> WARNING kernel: [ 1970.747974] schedule_hrtimeout_range_clock+0x10f/0x126
> WARNING kernel: [ 1970.747977] ? add_wait_queue+0x4d/0x84
> WARNING kernel: [ 1970.747982] poll_schedule_timeout+0x33/0x50
> WARNING kernel: [ 1970.747987] do_sys_poll+0x4a3/0x626
> WARNING kernel: [ 1970.747993] ? __se_sys_ppoll+0xdf/0xdf
> WARNING kernel: [ 1970.748000] __se_sys_poll+0x70/0xf7
> WARNING kernel: [ 1970.748003] do_syscall_64+0x51/0xa1
> WARNING kernel: [ 1970.748007] entry_SYSCALL_64_after_hwframe+0x5c/0xc6
> WARNING kernel: [ 1970.748012] RIP: 0033:0x7bc815769510
I saw that as well.... but from a robot.. not with a reproducer.
> dlserver should be started on an idle root cfs rq, when
> - enqueue on a non-throttled cfs_rq causing the root cfs rq to
> go non-idle, or
> - untthrottle results in the root cfs rq to go non-idle.
>
> Similarly dlserver should be stopped on a non-idle root cfs rq, when
> - dequeue on a non-throttled cfs_rq causing the root cfs rq to
> go idle, or
> - throttle results in the root cfs rq to go idle.
seem to make sense, I will add this check on v7.
Btw, as this is an ongoing thread discussion, instead of sending a patch, next time,
please reply to the patchset... it is easier for everybody to keep track.
-- Daniel
> > dlserver should be started on an idle root cfs rq, when
> > - enqueue on a non-throttled cfs_rq causing the root cfs rq to
> > go non-idle, or
> > - untthrottle results in the root cfs rq to go non-idle.
> >
> > Similarly dlserver should be stopped on a non-idle root cfs rq, when
> > - dequeue on a non-throttled cfs_rq causing the root cfs rq to
> > go idle, or
> > - throttle results in the root cfs rq to go idle.
>
>
> seem to make sense, I will add this check on v7.
>
Thanks!
> Btw, as this is an ongoing thread discussion, instead of sending a patch, next time,
> please reply to the patchset... it is easier for everybody to keep track.
>
Sorry about this. Will reply to the patchset in the future.
Thanks,
Vineeth