2008-01-24 19:38:20

by Miklos Szeredi

Subject: [patch 12/26] mount options: fix ext4

From: Miklos Szeredi <[email protected]>

Add stripe= option to /proc/mounts for ext4 filesystems.

Signed-off-by: Miklos Szeredi <[email protected]>
---

Index: linux/fs/ext4/super.c
===================================================================
--- linux.orig/fs/ext4/super.c 2008-01-23 12:57:07.000000000 +0100
+++ linux/fs/ext4/super.c 2008-01-23 21:43:51.000000000 +0100
@@ -742,7 +742,8 @@ static int ext4_show_options(struct seq_
seq_puts(seq, ",nomballoc");
if (!test_opt(sb, DELALLOC))
seq_puts(seq, ",nodelalloc");
-
+ if (sbi->s_stripe)
+ seq_printf(seq, ",stripe=%lu", sbi->s_stripe);

/*
* journal mode get enabled in different ways

--

2008-01-25 14:37:35

by Jan Kara

Subject: Re: [patch 12/26] mount options: fix ext4

> From: Miklos Szeredi <[email protected]>
>
> Add stripe= option to /proc/mounts for ext4 filesystems.
>
> Signed-off-by: Miklos Szeredi <[email protected]>
> ---
>
> Index: linux/fs/ext4/super.c
> ===================================================================
> --- linux.orig/fs/ext4/super.c 2008-01-23 12:57:07.000000000 +0100
> +++ linux/fs/ext4/super.c 2008-01-23 21:43:51.000000000 +0100
> @@ -742,7 +742,8 @@ static int ext4_show_options(struct seq_
> seq_puts(seq, ",nomballoc");
> if (!test_opt(sb, DELALLOC))
> seq_puts(seq, ",nodelalloc");
> -
> + if (sbi->s_stripe)
> + seq_printf(seq, ",stripe=%lu", sbi->s_stripe);
I think this should go via ext4 patch queue... Besides that the patch
is fine. Mingming, will you pickup the patch?

Honza
--
Jan Kara <[email protected]>
SuSE CR Labs

2008-01-25 17:35:37

by Mingming Cao

Subject: Re: [patch 12/26] mount options: fix ext4

On Thu, 2008-01-24 at 20:33 +0100, Miklos Szeredi wrote:
> plain text document attachment (ext4_opts.patch)
> From: Miklos Szeredi <[email protected]>
>
> Add stripe= option to /proc/mounts for ext4 filesystems.
>
> Signed-off-by: Miklos Szeredi <[email protected]>
> ---
>
> Index: linux/fs/ext4/super.c
> ===================================================================
> --- linux.orig/fs/ext4/super.c 2008-01-23 12:57:07.000000000 +0100
> +++ linux/fs/ext4/super.c 2008-01-23 21:43:51.000000000 +0100
> @@ -742,7 +742,8 @@ static int ext4_show_options(struct seq_
> seq_puts(seq, ",nomballoc");
> if (!test_opt(sb, DELALLOC))
> seq_puts(seq, ",nodelalloc");
> -
> + if (sbi->s_stripe)
> + seq_printf(seq, ",stripe=%lu", sbi->s_stripe);
>
> /*
> * journal mode get enabled in different ways
>

Added to ext4 patch queue. Thanks!
http://repo.or.cz/w/ext4-patch-queue.git

Mingming

2008-01-25 20:24:12

by Andreas Dilger

Subject: Re: [patch 12/26] mount options: fix ext4

On Jan 24, 2008 20:33 +0100, Miklos Szeredi wrote:
> Add stripe= option to /proc/mounts for ext4 filesystems.
>
> Signed-off-by: Miklos Szeredi <[email protected]>

Acked-by: Andreas Dilger <[email protected]>

> Index: linux/fs/ext4/super.c
> ===================================================================
> --- linux.orig/fs/ext4/super.c 2008-01-23 12:57:07.000000000 +0100
> +++ linux/fs/ext4/super.c 2008-01-23 21:43:51.000000000 +0100
> @@ -742,7 +742,8 @@ static int ext4_show_options(struct seq_
> seq_puts(seq, ",nomballoc");
> if (!test_opt(sb, DELALLOC))
> seq_puts(seq, ",nodelalloc");
> -
> + if (sbi->s_stripe)
> + seq_printf(seq, ",stripe=%lu", sbi->s_stripe);
>
> /*
> * journal mode get enabled in different ways

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.