2008-01-24 19:40:24

by Miklos Szeredi

Subject: [patch 18/26] mount options: fix isofs

From: Miklos Szeredi <[email protected]>

Add a .show_options super operation to isofs.

Use generic_show_options() and save the complete option string in
isofs_fill_super().

Signed-off-by: Miklos Szeredi <[email protected]>
---

Index: linux/fs/isofs/inode.c
===================================================================
--- linux.orig/fs/isofs/inode.c 2008-01-17 19:00:55.000000000 +0100
+++ linux/fs/isofs/inode.c 2008-01-23 22:07:51.000000000 +0100
@@ -110,6 +110,7 @@ static const struct super_operations iso
.put_super = isofs_put_super,
.statfs = isofs_statfs,
.remount_fs = isofs_remount,
+ .show_options = generic_show_options,
};


@@ -554,6 +555,8 @@ static int isofs_fill_super(struct super
int table, error = -EINVAL;
unsigned int vol_desc_start;

+ save_mount_options(s, data);
+
sbi = kzalloc(sizeof(*sbi), GFP_KERNEL);
if (!sbi)
return -ENOMEM;

--

2008-01-25 14:43:14

by Jan Kara

Subject: Re: [patch 18/26] mount options: fix isofs

> From: Miklos Szeredi <[email protected]>
>
> Add a .show_options super operation to isofs.
>
> Use generic_show_options() and save the complete option string in
> isofs_fill_super().
>
> Signed-off-by: Miklos Szeredi <[email protected]>
> ---
>
> Index: linux/fs/isofs/inode.c
> ===================================================================
> --- linux.orig/fs/isofs/inode.c 2008-01-17 19:00:55.000000000 +0100
> +++ linux/fs/isofs/inode.c 2008-01-23 22:07:51.000000000 +0100
> @@ -110,6 +110,7 @@ static const struct super_operations iso
> .put_super = isofs_put_super,
> .statfs = isofs_statfs,
> .remount_fs = isofs_remount,
> + .show_options = generic_show_options,
> };
>
>
> @@ -554,6 +555,8 @@ static int isofs_fill_super(struct super
> int table, error = -EINVAL;
> unsigned int vol_desc_start;
>
> + save_mount_options(s, data);
> +
> sbi = kzalloc(sizeof(*sbi), GFP_KERNEL);
> if (!sbi)
> return -ENOMEM;
Looks, fine.
Acked-by: Jan Kara <[email protected]>

Honza
--
Jan Kara <[email protected]>
SuSE CR Labs